Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch Dask client shutdown error #869

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

RobbeSneyders
Copy link
Member

A component in my pipeline failed due to an error during the client shutdown. While this is not ideal, it should not make the component fail.

I'm just wondering if we should fix it one level up and wrap the component.teardown() method in the try ... exctept ... block instead.

Copy link
Contributor

@mrchtr mrchtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@GeorgesLorre GeorgesLorre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sensible

@RobbeSneyders RobbeSneyders merged commit 5a4a64c into main Feb 21, 2024
8 of 9 checks passed
@RobbeSneyders RobbeSneyders deleted the bugfix/catch-shutdown-error branch February 21, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants