Enable default component arguments #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeMoussalli
added
Core
3 tasks
RobbeSneyders
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
Thanks @PhilippeMoussalli, just some suggestions to make the documentation more clear.
fondant/component.py
Outdated
| return parser.parse_args() | ||
| @staticmethod | ||
| def optional_fondant_arguments() -> t.List[str]: | ||
| return [] |
There was a problem hiding this comment.
I would expect the output_manifest_path here
There was a problem hiding this comment.
good catch, will change it
Co-authored-by: Robbe Sneyders <[email protected]>
Co-authored-by: Robbe Sneyders <[email protected]>
Hakimovich99
pushed a commit
that referenced
this pull request
Oct 16, 2023
PR that enables adding default arguments as discussed in #179. Users can now define default arguments in the component specs. Those arguments do not have to be explicitly defined in the `ComponentOp` but could still be overridden. Note: please review this [PR](#196) beforehand since I am branched off from it. Created a separate ticket to do the necessary changes #198. Best to handle it in a separate PR. --------- Co-authored-by: Robbe Sneyders <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR that enables adding default arguments as discussed in #179.
Users can now define default arguments in the component specs. Those arguments do not have to be explicitly defined in the
ComponentOpbut could still be overridden.Note: please review this PR beforehand since I am branched off from it.
Created a separate ticket to do the necessary changes #198. Best to handle it in a separate PR.