Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update component to use default argument where necessary #198

Closed
PhilippeMoussalli opened this issue Jun 12, 2023 · 0 comments · Fixed by #289
Closed

Update component to use default argument where necessary #198

PhilippeMoussalli opened this issue Jun 12, 2023 · 0 comments · Fixed by #289
Assignees
@PhilippeMoussalli
Labels
Components Implementation of components

Comments

@PhilippeMoussalli
Copy link
Contributor

PhilippeMoussalli commented Jun 12, 2023 •
edited
Loading

Related to #199
@PhilippeMoussalli PhilippeMoussalli converted this from a draft issue Jun 12, 2023
@PhilippeMoussalli PhilippeMoussalli mentioned this issue Jun 12, 2023
Merged
PhilippeMoussalli added a commit that referenced this issue Jun 13, 2023
@PhilippeMoussalli @RobbeSneyders
Enable default component arguments (#199)
e90ac78 
PR that enables adding default arguments as discussed in #179. 

Users can now define default arguments in the component specs. Those
arguments do not have to be explicitly defined in the `ComponentOp` but
could still be overridden.

Note: please review this
[PR](#196) beforehand since I am
branched off from it.

Created a separate ticket to do the necessary changes #198. Best to
handle it in a separate PR.

---------

Co-authored-by: Robbe Sneyders <[email protected]>
@RobbeSneyders RobbeSneyders moved this from Breakdown to Ready for development in Fondant development Jun 29, 2023
@RobbeSneyders RobbeSneyders added the Components Implementation of components label Jun 29, 2023
@PhilippeMoussalli PhilippeMoussalli moved this from Ready for development to In Progress in Fondant development Jul 11, 2023
@PhilippeMoussalli PhilippeMoussalli self-assigned this Jul 11, 2023
@PhilippeMoussalli PhilippeMoussalli linked a pull request Jul 11, 2023 that will close this issue
Add defaults to components #289
Merged
@PhilippeMoussalli PhilippeMoussalli moved this from In Progress to Validation in Fondant development Jul 11, 2023
@github-project-automation github-project-automation bot moved this from Validation to Done in Fondant development Jul 12, 2023
Hakimovich99 pushed a commit that referenced this issue Oct 16, 2023
@PhilippeMoussalli @RobbeSneyders
Enable default component arguments (#199)
0e8ebb8 
PR that enables adding default arguments as discussed in #179. 

Users can now define default arguments in the component specs. Those
arguments do not have to be explicitly defined in the `ComponentOp` but
could still be overridden.

Note: please review this
[PR](#196) beforehand since I am
branched off from it.

Created a separate ticket to do the necessary changes #198. Best to
handle it in a separate PR.

---------

Co-authored-by: Robbe Sneyders <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhilippeMoussalli PhilippeMoussalli

Labels
Components Implementation of components
Projects
Fondant development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add defaults to components ml6team/fondant
2 participants
@RobbeSneyders @PhilippeMoussalli