New architecture support #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When it will be merged? |
|
@mkuczera could you review this PR please? |
mkuczera
approved these changes
Mar 19, 2023
github-merge-queue bot
referenced
this pull request
in valora-inc/wallet
Apr 27, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-haptic-feedback](https://togithub.com/mkuczera/react-native-haptic-feedback) | [`^1.14.0` -> `^2.2.0`](https://renovatebot.com/diffs/npm/react-native-haptic-feedback/1.14.0/2.2.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mkuczera/react-native-haptic-feedback (react-native-haptic-feedback)</summary> ### [`v2.2.0`](https://togithub.com/mkuczera/react-native-haptic-feedback/releases/tag/v2.2.0): Fixing failure releases [Compare Source](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/52bc4342fd30422c018066783c92379d7b37f5c7...v2.2.0) Due to some major changes in v2 they introduced a lot of issues, especially regarding Android. The previous versions are deprecated and 2.2.0 should be considered as latest. Thanks to - [@​rajaasim](https://togithub.com/rajaasim) - [@​yunchanpark](https://togithub.com/yunchanpark) \[[#​111](https://togithub.com/mkuczera/react-native-haptic-feedback/issues/111) ]\(fix: RNReactNativeHapticFeedbackPackage.java missing import) - [@​abuciuman](https://togithub.com/abuciuman) \[[#​109](https://togithub.com/mkuczera/react-native-haptic-feedback/issues/109) ]\(Refactor: Align Package Name with Directory Structure for vibrateFactory) - [@​NotArtyom](https://togithub.com/NotArtyom) \[[#​102](https://togithub.com/mkuczera/react-native-haptic-feedback/issues/102)]\(FIX: iOS build issues with new architecture) - [@​Lavegaa](https://togithub.com/Lavegaa) \[[#​108](https://togithub.com/mkuczera/react-native-haptic-feedback/issues/108)]\(Fix Android Vibration enable condition) - [@​alexhernandez](https://togithub.com/alexhernandez) \[[#​105](https://togithub.com/mkuczera/react-native-haptic-feedback/issues/105) ]\(Android RN 72 Support - Update build.gradle w/ Namespace) - [@​thenishantgiri](https://togithub.com/thenishantgiri) \[[#​110](https://togithub.com/mkuczera/react-native-haptic-feedback/issues/110)]\(🚀 Revamped Documentation: Clearer Instructions, Enhanced Formatting, and Improved Readability ) ### [`v2.1.0`](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/d9bfa28b6d043967a88148383d57b165c1095e46...52bc4342fd30422c018066783c92379d7b37f5c7) [Compare Source](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/d9bfa28b6d043967a88148383d57b165c1095e46...52bc4342fd30422c018066783c92379d7b37f5c7) ### [`v2.0.3`](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/d0f20959ef982fb30bf0ddcd7c156994c657f034...d9bfa28b6d043967a88148383d57b165c1095e46) [Compare Source](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/d0f20959ef982fb30bf0ddcd7c156994c657f034...d9bfa28b6d043967a88148383d57b165c1095e46) ### [`v2.0.2`](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/31c45a21128639f18ef6197b30544cb43370bef3...d0f20959ef982fb30bf0ddcd7c156994c657f034) [Compare Source](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/31c45a21128639f18ef6197b30544cb43370bef3...d0f20959ef982fb30bf0ddcd7c156994c657f034) ### [`v2.0.1`](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/v2.0.0...31c45a21128639f18ef6197b30544cb43370bef3) [Compare Source](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/v2.0.0...31c45a21128639f18ef6197b30544cb43370bef3) ### [`v2.0.0`](https://togithub.com/mkuczera/react-native-haptic-feedback/releases/tag/v2.0.0): New Arch support [Compare Source](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/v1.14.0...v2.0.0) #### What's Changed ##### Main changes: - New architecture support by [@​j-piasecki](https://togithub.com/j-piasecki) in [https://github.com/mkuczera/react-native-haptic-feedback/pull/90](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/90) - Update to Fabric by [@​hansdesmedt](https://togithub.com/hansdesmedt) in [https://github.com/mkuczera/react-native-haptic-feedback/pull/89](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/89) ##### Further changes - android installation part updated on Readme file by [@​elmirsmylv](https://togithub.com/elmirsmylv) in [https://github.com/mkuczera/react-native-haptic-feedback/pull/83](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/83) - Updates the TypeScript definition by [@​matiaskorhonen](https://togithub.com/matiaskorhonen) in [https://github.com/mkuczera/react-native-haptic-feedback/pull/86](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/86) - [#​47](https://togithub.com/mkuczera/react-native-haptic-feedback/issues/47) Add default haptic feedback for iPhone 6s or IPhone6S Plus. by [@​Romick2005](https://togithub.com/Romick2005) in [https://github.com/mkuczera/react-native-haptic-feedback/pull/80](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/80) #### New Contributors - [@​elmirsmylv](https://togithub.com/elmirsmylv) made their first contribution in [https://github.com/mkuczera/react-native-haptic-feedback/pull/83](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/83) - [@​matiaskorhonen](https://togithub.com/matiaskorhonen) made their first contribution in [https://github.com/mkuczera/react-native-haptic-feedback/pull/86](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/86) - [@​Romick2005](https://togithub.com/Romick2005) made their first contribution in [https://github.com/mkuczera/react-native-haptic-feedback/pull/80](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/80) - [@​j-piasecki](https://togithub.com/j-piasecki) made their first contribution in [https://github.com/mkuczera/react-native-haptic-feedback/pull/90](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/90) - [@​hansdesmedt](https://togithub.com/hansdesmedt) made their first contribution in [https://github.com/mkuczera/react-native-haptic-feedback/pull/89](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/89) **Full Changelog**: mkuczera/react-native-haptic-feedback@v1.14.0...v2.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMDEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjMwMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Satish Ravi <[email protected]> Co-authored-by: valora-bot <[email protected]>
shottah
referenced
this pull request
in zed-io/kolektivo
May 15, 2024
](https://renovatebot.com){kind=link}
…ra-inc#5292) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-haptic-feedback](https://togithub.com/mkuczera/react-native-haptic-feedback) | [`^1.14.0` -> `^2.2.0`](https://renovatebot.com/diffs/npm/react-native-haptic-feedback/1.14.0/2.2.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mkuczera/react-native-haptic-feedback (react-native-haptic-feedback)</summary> ### [`v2.2.0`](https://togithub.com/mkuczera/react-native-haptic-feedback/releases/tag/v2.2.0): Fixing failure releases [Compare Source](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/52bc4342fd30422c018066783c92379d7b37f5c7...v2.2.0) Due to some major changes in v2 they introduced a lot of issues, especially regarding Android. The previous versions are deprecated and 2.2.0 should be considered as latest. Thanks to - [@​rajaasim](https://togithub.com/rajaasim) - [@​yunchanpark](https://togithub.com/yunchanpark) \[[#​111](https://togithub.com/mkuczera/react-native-haptic-feedback/issues/111) ]\(fix: RNReactNativeHapticFeedbackPackage.java missing import) - [@​abuciuman](https://togithub.com/abuciuman) \[[#​109](https://togithub.com/mkuczera/react-native-haptic-feedback/issues/109) ]\(Refactor: Align Package Name with Directory Structure for vibrateFactory) - [@​NotArtyom](https://togithub.com/NotArtyom) \[[#​102](https://togithub.com/mkuczera/react-native-haptic-feedback/issues/102)]\(FIX: iOS build issues with new architecture) - [@​Lavegaa](https://togithub.com/Lavegaa) \[[#​108](https://togithub.com/mkuczera/react-native-haptic-feedback/issues/108)]\(Fix Android Vibration enable condition) - [@​alexhernandez](https://togithub.com/alexhernandez) \[[#​105](https://togithub.com/mkuczera/react-native-haptic-feedback/issues/105) ]\(Android RN 72 Support - Update build.gradle w/ Namespace) - [@​thenishantgiri](https://togithub.com/thenishantgiri) \[[#​110](https://togithub.com/mkuczera/react-native-haptic-feedback/issues/110)]\(🚀 Revamped Documentation: Clearer Instructions, Enhanced Formatting, and Improved Readability ) ### [`v2.1.0`](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/d9bfa28b6d043967a88148383d57b165c1095e46...52bc4342fd30422c018066783c92379d7b37f5c7) [Compare Source](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/d9bfa28b6d043967a88148383d57b165c1095e46...52bc4342fd30422c018066783c92379d7b37f5c7) ### [`v2.0.3`](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/d0f20959ef982fb30bf0ddcd7c156994c657f034...d9bfa28b6d043967a88148383d57b165c1095e46) [Compare Source](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/d0f20959ef982fb30bf0ddcd7c156994c657f034...d9bfa28b6d043967a88148383d57b165c1095e46) ### [`v2.0.2`](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/31c45a21128639f18ef6197b30544cb43370bef3...d0f20959ef982fb30bf0ddcd7c156994c657f034) [Compare Source](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/31c45a21128639f18ef6197b30544cb43370bef3...d0f20959ef982fb30bf0ddcd7c156994c657f034) ### [`v2.0.1`](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/v2.0.0...31c45a21128639f18ef6197b30544cb43370bef3) [Compare Source](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/v2.0.0...31c45a21128639f18ef6197b30544cb43370bef3) ### [`v2.0.0`](https://togithub.com/mkuczera/react-native-haptic-feedback/releases/tag/v2.0.0): New Arch support [Compare Source](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/v1.14.0...v2.0.0) #### What's Changed ##### Main changes: - New architecture support by [@​j-piasecki](https://togithub.com/j-piasecki) in [https://github.com/mkuczera/react-native-haptic-feedback/pull/90](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/90) - Update to Fabric by [@​hansdesmedt](https://togithub.com/hansdesmedt) in [https://github.com/mkuczera/react-native-haptic-feedback/pull/89](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/89) ##### Further changes - android installation part updated on Readme file by [@​elmirsmylv](https://togithub.com/elmirsmylv) in [https://github.com/mkuczera/react-native-haptic-feedback/pull/83](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/83) - Updates the TypeScript definition by [@​matiaskorhonen](https://togithub.com/matiaskorhonen) in [https://github.com/mkuczera/react-native-haptic-feedback/pull/86](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/86) - [#​47](https://togithub.com/mkuczera/react-native-haptic-feedback/issues/47) Add default haptic feedback for iPhone 6s or IPhone6S Plus. by [@​Romick2005](https://togithub.com/Romick2005) in [https://github.com/mkuczera/react-native-haptic-feedback/pull/80](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/80) #### New Contributors - [@​elmirsmylv](https://togithub.com/elmirsmylv) made their first contribution in [https://github.com/mkuczera/react-native-haptic-feedback/pull/83](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/83) - [@​matiaskorhonen](https://togithub.com/matiaskorhonen) made their first contribution in [https://github.com/mkuczera/react-native-haptic-feedback/pull/86](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/86) - [@​Romick2005](https://togithub.com/Romick2005) made their first contribution in [https://github.com/mkuczera/react-native-haptic-feedback/pull/80](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/80) - [@​j-piasecki](https://togithub.com/j-piasecki) made their first contribution in [https://github.com/mkuczera/react-native-haptic-feedback/pull/90](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/90) - [@​hansdesmedt](https://togithub.com/hansdesmedt) made their first contribution in [https://github.com/mkuczera/react-native-haptic-feedback/pull/89](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/89) **Full Changelog**: mkuczera/react-native-haptic-feedback@v1.14.0...v2.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMDEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjMwMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Satish Ravi <[email protected]> Co-authored-by: valora-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adding New Architecture support to the library 🎉
We at Software Mansion have been working on improving support for the new architecture for quite a while now. If you need help with anything related to New Architecture, like:
or you just want to ask any questions, hit us up on [email protected]
This PR builds on top of #89 to bring the new architecture changes to the library. Main changes that I've added:
build.gradleso that it can recognize current RN version and adapt accordinglycodegenConfigfield inpackage.jsonto use the new config syntax