-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Fabric #89
Update to Fabric #89
Conversation
hey can you add the label 'hacktoberfest' 🙏 |
Awesome |
damn i was about to try my hand at porting it today, glad it's already done |
Hey @mkuczera, can you check this? 🙏 |
Update on this: can we get it compatible with the 0.71 fabric changes? @hansdesmedt |
Hi there, sorry for the late response. |
@mkuczera that would be awesome! I know there's a few C++ module renames that happened |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-haptic-feedback](https://togithub.com/mkuczera/react-native-haptic-feedback) | [`^1.14.0` -> `^2.2.0`](https://renovatebot.com/diffs/npm/react-native-haptic-feedback/1.14.0/2.2.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-haptic-feedback/2.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-haptic-feedback/2.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-haptic-feedback/1.14.0/2.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-haptic-feedback/1.14.0/2.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mkuczera/react-native-haptic-feedback (react-native-haptic-feedback)</summary> ### [`v2.2.0`](https://togithub.com/mkuczera/react-native-haptic-feedback/releases/tag/v2.2.0): Fixing failure releases [Compare Source](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/52bc4342fd30422c018066783c92379d7b37f5c7...v2.2.0) Due to some major changes in v2 they introduced a lot of issues, especially regarding Android. The previous versions are deprecated and 2.2.0 should be considered as latest. Thanks to - [@​rajaasim](https://togithub.com/rajaasim) - [@​yunchanpark](https://togithub.com/yunchanpark) \[[#​111](https://togithub.com/mkuczera/react-native-haptic-feedback/issues/111) ]\(fix: RNReactNativeHapticFeedbackPackage.java missing import) - [@​abuciuman](https://togithub.com/abuciuman) \[[#​109](https://togithub.com/mkuczera/react-native-haptic-feedback/issues/109) ]\(Refactor: Align Package Name with Directory Structure for vibrateFactory) - [@​NotArtyom](https://togithub.com/NotArtyom) \[[#​102](https://togithub.com/mkuczera/react-native-haptic-feedback/issues/102)]\(FIX: iOS build issues with new architecture) - [@​Lavegaa](https://togithub.com/Lavegaa) \[[#​108](https://togithub.com/mkuczera/react-native-haptic-feedback/issues/108)]\(Fix Android Vibration enable condition) - [@​alexhernandez](https://togithub.com/alexhernandez) \[[#​105](https://togithub.com/mkuczera/react-native-haptic-feedback/issues/105) ]\(Android RN 72 Support - Update build.gradle w/ Namespace) - [@​thenishantgiri](https://togithub.com/thenishantgiri) \[[#​110](https://togithub.com/mkuczera/react-native-haptic-feedback/issues/110)]\(🚀 Revamped Documentation: Clearer Instructions, Enhanced Formatting, and Improved Readability ) ### [`v2.1.0`](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/d9bfa28b6d043967a88148383d57b165c1095e46...52bc4342fd30422c018066783c92379d7b37f5c7) [Compare Source](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/d9bfa28b6d043967a88148383d57b165c1095e46...52bc4342fd30422c018066783c92379d7b37f5c7) ### [`v2.0.3`](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/d0f20959ef982fb30bf0ddcd7c156994c657f034...d9bfa28b6d043967a88148383d57b165c1095e46) [Compare Source](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/d0f20959ef982fb30bf0ddcd7c156994c657f034...d9bfa28b6d043967a88148383d57b165c1095e46) ### [`v2.0.2`](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/31c45a21128639f18ef6197b30544cb43370bef3...d0f20959ef982fb30bf0ddcd7c156994c657f034) [Compare Source](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/31c45a21128639f18ef6197b30544cb43370bef3...d0f20959ef982fb30bf0ddcd7c156994c657f034) ### [`v2.0.1`](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/v2.0.0...31c45a21128639f18ef6197b30544cb43370bef3) [Compare Source](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/v2.0.0...31c45a21128639f18ef6197b30544cb43370bef3) ### [`v2.0.0`](https://togithub.com/mkuczera/react-native-haptic-feedback/releases/tag/v2.0.0): New Arch support [Compare Source](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/v1.14.0...v2.0.0) #### What's Changed ##### Main changes: - New architecture support by [@​j-piasecki](https://togithub.com/j-piasecki) in [https://github.com/mkuczera/react-native-haptic-feedback/pull/90](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/90) - Update to Fabric by [@​hansdesmedt](https://togithub.com/hansdesmedt) in [https://github.com/mkuczera/react-native-haptic-feedback/pull/89](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/89) ##### Further changes - android installation part updated on Readme file by [@​elmirsmylv](https://togithub.com/elmirsmylv) in [https://github.com/mkuczera/react-native-haptic-feedback/pull/83](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/83) - Updates the TypeScript definition by [@​matiaskorhonen](https://togithub.com/matiaskorhonen) in [https://github.com/mkuczera/react-native-haptic-feedback/pull/86](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/86) - [#​47](https://togithub.com/mkuczera/react-native-haptic-feedback/issues/47) Add default haptic feedback for iPhone 6s or IPhone6S Plus. by [@​Romick2005](https://togithub.com/Romick2005) in [https://github.com/mkuczera/react-native-haptic-feedback/pull/80](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/80) #### New Contributors - [@​elmirsmylv](https://togithub.com/elmirsmylv) made their first contribution in [https://github.com/mkuczera/react-native-haptic-feedback/pull/83](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/83) - [@​matiaskorhonen](https://togithub.com/matiaskorhonen) made their first contribution in [https://github.com/mkuczera/react-native-haptic-feedback/pull/86](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/86) - [@​Romick2005](https://togithub.com/Romick2005) made their first contribution in [https://github.com/mkuczera/react-native-haptic-feedback/pull/80](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/80) - [@​j-piasecki](https://togithub.com/j-piasecki) made their first contribution in [https://github.com/mkuczera/react-native-haptic-feedback/pull/90](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/90) - [@​hansdesmedt](https://togithub.com/hansdesmedt) made their first contribution in [https://github.com/mkuczera/react-native-haptic-feedback/pull/89](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/89) **Full Changelog**: mkuczera/react-native-haptic-feedback@v1.14.0...v2.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMDEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjMwMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Satish Ravi <[email protected]> Co-authored-by: valora-bot <[email protected]>
…ra-inc#5292) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-haptic-feedback](https://togithub.com/mkuczera/react-native-haptic-feedback) | [`^1.14.0` -> `^2.2.0`](https://renovatebot.com/diffs/npm/react-native-haptic-feedback/1.14.0/2.2.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/react-native-haptic-feedback/2.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-native-haptic-feedback/2.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-native-haptic-feedback/1.14.0/2.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-native-haptic-feedback/1.14.0/2.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mkuczera/react-native-haptic-feedback (react-native-haptic-feedback)</summary> ### [`v2.2.0`](https://togithub.com/mkuczera/react-native-haptic-feedback/releases/tag/v2.2.0): Fixing failure releases [Compare Source](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/52bc4342fd30422c018066783c92379d7b37f5c7...v2.2.0) Due to some major changes in v2 they introduced a lot of issues, especially regarding Android. The previous versions are deprecated and 2.2.0 should be considered as latest. Thanks to - [@​rajaasim](https://togithub.com/rajaasim) - [@​yunchanpark](https://togithub.com/yunchanpark) \[[#​111](https://togithub.com/mkuczera/react-native-haptic-feedback/issues/111) ]\(fix: RNReactNativeHapticFeedbackPackage.java missing import) - [@​abuciuman](https://togithub.com/abuciuman) \[[#​109](https://togithub.com/mkuczera/react-native-haptic-feedback/issues/109) ]\(Refactor: Align Package Name with Directory Structure for vibrateFactory) - [@​NotArtyom](https://togithub.com/NotArtyom) \[[#​102](https://togithub.com/mkuczera/react-native-haptic-feedback/issues/102)]\(FIX: iOS build issues with new architecture) - [@​Lavegaa](https://togithub.com/Lavegaa) \[[#​108](https://togithub.com/mkuczera/react-native-haptic-feedback/issues/108)]\(Fix Android Vibration enable condition) - [@​alexhernandez](https://togithub.com/alexhernandez) \[[#​105](https://togithub.com/mkuczera/react-native-haptic-feedback/issues/105) ]\(Android RN 72 Support - Update build.gradle w/ Namespace) - [@​thenishantgiri](https://togithub.com/thenishantgiri) \[[#​110](https://togithub.com/mkuczera/react-native-haptic-feedback/issues/110)]\(🚀 Revamped Documentation: Clearer Instructions, Enhanced Formatting, and Improved Readability ) ### [`v2.1.0`](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/d9bfa28b6d043967a88148383d57b165c1095e46...52bc4342fd30422c018066783c92379d7b37f5c7) [Compare Source](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/d9bfa28b6d043967a88148383d57b165c1095e46...52bc4342fd30422c018066783c92379d7b37f5c7) ### [`v2.0.3`](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/d0f20959ef982fb30bf0ddcd7c156994c657f034...d9bfa28b6d043967a88148383d57b165c1095e46) [Compare Source](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/d0f20959ef982fb30bf0ddcd7c156994c657f034...d9bfa28b6d043967a88148383d57b165c1095e46) ### [`v2.0.2`](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/31c45a21128639f18ef6197b30544cb43370bef3...d0f20959ef982fb30bf0ddcd7c156994c657f034) [Compare Source](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/31c45a21128639f18ef6197b30544cb43370bef3...d0f20959ef982fb30bf0ddcd7c156994c657f034) ### [`v2.0.1`](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/v2.0.0...31c45a21128639f18ef6197b30544cb43370bef3) [Compare Source](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/v2.0.0...31c45a21128639f18ef6197b30544cb43370bef3) ### [`v2.0.0`](https://togithub.com/mkuczera/react-native-haptic-feedback/releases/tag/v2.0.0): New Arch support [Compare Source](https://togithub.com/mkuczera/react-native-haptic-feedback/compare/v1.14.0...v2.0.0) #### What's Changed ##### Main changes: - New architecture support by [@​j-piasecki](https://togithub.com/j-piasecki) in [https://github.com/mkuczera/react-native-haptic-feedback/pull/90](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/90) - Update to Fabric by [@​hansdesmedt](https://togithub.com/hansdesmedt) in [https://github.com/mkuczera/react-native-haptic-feedback/pull/89](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/89) ##### Further changes - android installation part updated on Readme file by [@​elmirsmylv](https://togithub.com/elmirsmylv) in [https://github.com/mkuczera/react-native-haptic-feedback/pull/83](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/83) - Updates the TypeScript definition by [@​matiaskorhonen](https://togithub.com/matiaskorhonen) in [https://github.com/mkuczera/react-native-haptic-feedback/pull/86](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/86) - [#​47](https://togithub.com/mkuczera/react-native-haptic-feedback/issues/47) Add default haptic feedback for iPhone 6s or IPhone6S Plus. by [@​Romick2005](https://togithub.com/Romick2005) in [https://github.com/mkuczera/react-native-haptic-feedback/pull/80](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/80) #### New Contributors - [@​elmirsmylv](https://togithub.com/elmirsmylv) made their first contribution in [https://github.com/mkuczera/react-native-haptic-feedback/pull/83](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/83) - [@​matiaskorhonen](https://togithub.com/matiaskorhonen) made their first contribution in [https://github.com/mkuczera/react-native-haptic-feedback/pull/86](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/86) - [@​Romick2005](https://togithub.com/Romick2005) made their first contribution in [https://github.com/mkuczera/react-native-haptic-feedback/pull/80](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/80) - [@​j-piasecki](https://togithub.com/j-piasecki) made their first contribution in [https://github.com/mkuczera/react-native-haptic-feedback/pull/90](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/90) - [@​hansdesmedt](https://togithub.com/hansdesmedt) made their first contribution in [https://github.com/mkuczera/react-native-haptic-feedback/pull/89](https://togithub.com/mkuczera/react-native-haptic-feedback/pull/89) **Full Changelog**: mkuczera/react-native-haptic-feedback@v1.14.0...v2.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMDEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjMwMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Satish Ravi <[email protected]> Co-authored-by: valora-bot <[email protected]>
#87