Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move historySize setting to mbean creation. #175

Closed
mk23 opened this issue Feb 9, 2018 · 0 comments
Closed

Move historySize setting to mbean creation. #175

mk23 opened this issue Feb 9, 2018 · 0 comments
Assignees
@mk23
Labels
backend api refactor
Milestone
jmxproxy.3.4.0

Comments

@mk23
Copy link
Owner

mk23 commented Feb 9, 2018 •
edited
Loading

It doesn't make sense to be setting the history size per attribute. The entire mbean should have a history size and adding attributes should just include the name and the value.

Add tests to verify.
@mk23 mk23 added this to the jmxproxy.3.4.0 milestone Feb 9, 2018
@mk23 mk23 self-assigned this Feb 9, 2018
mk23 added a commit that referenced this issue Feb 9, 2018
@mk23
Issue #175: Move setting the history size from attribute to mbean cre…
eee0949 
…ation.
@mk23 mk23 closed this as completed Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mk23 mk23

Labels
backend api refactor
Projects
None yet
Milestone
jmxproxy.3.4.0
Development

No branches or pull requests
1 participant
@mk23