Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest jquery broke YUI compressor #138

Closed
mk23 opened this issue Jan 1, 2017 · 1 comment
Closed

Latest jquery broke YUI compressor #138

mk23 opened this issue Jan 1, 2017 · 1 comment
Assignees
@mk23
Labels
bug user interface
Milestone
jmxproxy.3.3.5

Comments

@mk23
Copy link
Owner

mk23 commented Jan 1, 2017

Looks like yui doesn't support ecmascript5+. Issue reported almost a year ago with no traction: yui/yuicompressor#234

Switch to using CLOSURE compiler for js which seems to work better.

        <jsEngine>CLOSURE</jsEngine>
        <closureLanguage>ECMASCRIPT5</closureLanguage>
@mk23 mk23 added this to the jmxproxy.3.3.5 milestone Jan 1, 2017
@mk23 mk23 self-assigned this Jan 1, 2017
@mk23
Copy link
Owner Author

mk23 commented Jan 1, 2017

Closure compiler leaves line breaks every 500 or so chars (https://developers.google.com/closure/compiler/faq?csw=1#linefeeds) so also need to update the minification test.

mk23 added a commit that referenced this issue Jan 1, 2017
@mk23
Issue #138: Use closure compiler for js minification.
a782660
@mk23 mk23 closed this as completed Jan 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mk23 mk23

Labels
bug user interface
Projects
None yet
Milestone
jmxproxy.3.3.5
Development

No branches or pull requests
1 participant
@mk23