Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code coverage: chain through interface methods in core classes. #126

Closed
mk23 opened this issue Jul 3, 2016 · 0 comments
Closed

Improve code coverage: chain through interface methods in core classes. #126

mk23 opened this issue Jul 3, 2016 · 0 comments
Assignees
@mk23
Labels
backend api enhancement
Milestone
jmxproxy.3.3.3

Comments

@mk23
Copy link
Owner

mk23 commented Jul 3, 2016

Call serializeWithType() from serialize() in core classes.

Covers missing calls in:
https://github.com/mk23/jmxproxy/blob/master/src/main/java/com/github/mk23/jmxproxy/core/Host.java#L135-L136
https://github.com/mk23/jmxproxy/blob/master/src/main/java/com/github/mk23/jmxproxy/core/MBean.java#L172-L173
https://github.com/mk23/jmxproxy/blob/master/src/main/java/com/github/mk23/jmxproxy/core/Attribute.java#L98-L99

Also remove unused method in Attribute.java in:
https://github.com/mk23/jmxproxy/blob/master/src/main/java/com/github/mk23/jmxproxy/core/Attribute.java#L74-L80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mk23 mk23

Labels
backend api enhancement
Projects
None yet
Milestone
jmxproxy.3.3.3
Development

No branches or pull requests
1 participant
@mk23