Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code coverage: extend expiration test #124

Closed
mk23 opened this issue Jul 2, 2016 · 0 comments
Closed

Improve code coverage: extend expiration test #124

mk23 opened this issue Jul 2, 2016 · 0 comments
Assignees
@mk23
Labels
backend api enhancement
Milestone
jmxproxy.3.3.3

Comments

@mk23
Copy link
Owner

mk23 commented Jul 2, 2016

Extend checkHostExpiration in JMXProxyResourceTest to allow for an extra run of cleanInterval to verify isExpired() properly returns false if the accessDuration hasn't been passed.

Covers other branch in:
https://github.com/mk23/jmxproxy/blob/master/src/main/java/com/github/mk23/jmxproxy/jmx/ConnectionWorker.java#L156
@mk23 mk23 added this to the jmxproxy.3.3.3 milestone Jul 2, 2016
@mk23 mk23 self-assigned this Jul 2, 2016
mk23 added a commit that referenced this issue Jul 3, 2016
@mk23
Issue #124: Extend expiration test to ensure cleaner thread fires whe…
68bf7bc 
…n appropriate.
@mk23 mk23 closed this as completed Jul 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mk23 mk23

Labels
backend api enhancement
Projects
None yet
Milestone
jmxproxy.3.3.3
Development

No branches or pull requests
1 participant
@mk23