-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable use in Windows #1
Conversation
Perfect, I had a few of these in a scratch workspace that I had forgotten to push, this is very helpful for completeness. |
I think that we need to bump the pixi-action version here as well to get CI to work? |
Done: 336447e . |
@mjcarroll no hurry or anything, but I guess the CI is awaiting for an approval on your side. |
I figured once I approved it once, it was good to go. Doesn't seem to be the case here. |
I compiled locally and found a few more fixes. The Linux build now fails on gz-rendering due to the issue mentioned in conda-forge/staged-recipes#13677 (comment), that is actually a workaround as the |
To give you an idea, the least intrusive fix I was able to find was: diff --git a/ogre/src/OgreRenderEngine.cc b/ogre/src/OgreRenderEngine.cc
index 7352e747..5c07bef2 100644
--- a/ogre/src/OgreRenderEngine.cc
+++ b/ogre/src/OgreRenderEngine.cc
@@ -19,6 +19,9 @@
#if !defined(__APPLE__) && !defined(_WIN32)
# include <X11/Xlib.h>
# include <X11/Xutil.h>
+# include <KHR/khrplatform.h>
+typedef khronos_ssize_t GLsizeiptr;
+typedef khronos_intptr_t GLintptr;
# include <GL/glx.h>
#endif on distros with modern OpenGL headers the typedef will just be redefined in |
I'm fine with this. I also don't think it blocks this PR. I know CI is broken, but would prefer we can keep iterating, since this is a low-stakes repo. |
By the way, eventually conda-forge may be some modern opengl headers (see conda-forge/staged-recipes#25919), so perhaps we do not even need to workaround that anymore. |
To complete the migration to gz-sim in my lab I need to eventually attack gazebosim/gz-sim#2089 . So I needed some way to quickly compile all gazebo distro easily.
Modifications:
python
tohelper.py
invocations as in Windows there is no shebangpixi.toml
unless necessaryActually requires gazebosim/gz-cmake#417 or dartsim/dart#1795 to be used out of the box, but it is still useful in this form, at least to me.