Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed "getStaringPoseFromAutoFile" to non-misspelled version #672

Closed
wants to merge 4 commits into from

Conversation

ironon
Copy link

@ironon ironon commented Apr 2, 2024

our programmers tore their hair out over this

@github-actions github-actions bot added the PathPlannerLib Changes to PathPlannerLib label Apr 2, 2024
@mjansen4857
Copy link
Owner

Can you add back a version of the method that is misspelled that just calls the correct method, then deprecate it? If the typo is just fixed this can't be released without breaking the code of everyone that uses that method.

@mjansen4857 mjansen4857 linked an issue Apr 4, 2024 that may be closed by this pull request
@ironon
Copy link
Author

ironon commented Apr 27, 2024

added 👍
good catch, I should have thought of that originally.

@mjansen4857
Copy link
Owner

No longer relevant as of #714

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PathPlannerLib Changes to PathPlannerLib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in Java lib: PathPlannerAuto.getStaringPoseFromAutoFile
2 participants