New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skin layout revamp #913

Closed

ferranpujolcamins wants to merge 37 commits into mixxxdj:master from ferranpujolcamins:skin-layout-revamp

Contributor

ferranpujolcamins commented Apr 3, 2016

Supersedes #639

ferranpujolcamins added 28 commits

April 2, 2016 09:30


          Removed layout option buttons from the top of LateNight.

e016d30

Centered the clock.


          Reordered view menu.

94e7b25


          Added "Show Library" check control to the view menu.

386721e


          Changed CO show_library_tab_small to show_library in LateNight.

This lets the view menu check option work in all circumstances.


          Added Show Eqs check control to the view Menu.

db93d5d


          Added Show Mixer check control in view menu.

925bf4b


          Added Show 4 decks check option to view menu.

e30c955


          LateNight: crossfader can now be hidden. Added "Show crossfader" chec…

da2bb21

…k option to view menu.


          Updated keyboard shortcuts for layout options.

2532b8f


          Added show crossfader option the Shade.

9be3c73


          LateNight: Library always visible when skin is med or full size.

95f766b

The library has been disconnected from show_library CO when the lower half of the skin is either in full or med mode.
This makes sense since there's always enough space for the library in both modes, even if the samplers, the fx chains and/or the mics are visible.
The library has been changed to minimum expanding height to accomodate to the height of visible sections samplers, fx and/or mic.
These changes also solve the library not showing up on Mixxx start if the samplers, fx or mics were selected on the small mode when Mixxx exit.


          Moved clock and latency meter to bottom bar. Moved Big library button…

02080a8

… to the left.


          Removed top toolbar.

d99a28b


          Unified all LateNight toolbars.

f06cc16


          Added the missing show library button to the bottom bar.

71678e7


          LateNight: Added 2/4 decks button to bottom bar.

2a3d7b5


          Added show preview deck button to the bottom bar.

4601fdd


          LateNight: Recentered the clock.

b8815ab


          LateNight: Added CPU label to the latency meter.

623235b


          LateNight: makes the mixer align on top.

1de8fb0


          Added show spinnies check option to the view menu.

5fadba6


          Removed unrelated files added by error.

a6b2624


          Reordered view menu.


          Updated keyboard shortcuts. The coverart shortcut is broken for all l…

bc07c6b

…ocales except spanish, russian and italian.


          LateNight: Changed show spinny button for crossfader assign button.

3c41659

Swapped it by quantize button so the layout is the same than the one on the sampler decks.


          Shade: switched to common show/hide control for both spinnies.

5f7de2b

Removed the show/hide spinny deck button and replaced for xFader assign.
Swaped position of xFader assign button and quantize button.


          LateNight: Added dividers to the bottom bar.

5c7f98b


          LateNight: hide the library button when its useless.

23c7da2

ferranpujolcamins mentioned this pull request

Skin layout revamp dev #639

Closed

Contributor Author

ferranpujolcamins commented Apr 3, 2016

Is this ready to merge?


          Merge branch 'master' into skin-layout-revamp

d9ae3f6

Member

ywwg commented Apr 13, 2016

We still need to give people access to the removed UI options: EQs, Vinyl, Mixer, Spinnies. Those need to go somewhere. Maybe a Deere-style menu?


          Added Mixer, Eq, Spinnies and Vinyl buttons to the toolbar.

a0c7523

Moved the clock next to the latency meter.

Contributor Author

ferranpujolcamins commented Apr 14, 2016

I don't see the point for a Deere style menu. It would require a click to open the menu and a click to toggle the button, so it doesn't offer any advantage over the view menu.

I've added them to the toolbar. Do you like it this way?

Contributor

Be-ing commented Apr 29, 2016 •

edited

Loading

I've added them to the toolbar. Do you like it this way?

I like that way. 👍

I don't know if this would actually be an improvement, but what about switching the middle and right sections of the bottom buttons?

Contributor

Be-ing commented Apr 29, 2016 •

edited

Loading

I think it is a little confusing that the right section of buttons only allows 1 button to be pressed but they look the same as the other buttons, which can have any number of them activated. Maybe make their background a slightly different color when activated?

Contributor Author

ferranpujolcamins commented Apr 29, 2016

I don't know if this would actually be an improvement, but what about switching the middle and right sections of the bottom buttons?

That's personal taste. I don't really care. What do others think?

I think it is a little confusing that the right section of buttons only allows 1 button to be pressed

If the window is big enough, they can all be active at the same time. I prefer keeping them the same color.

Contributor

Be-ing commented Apr 29, 2016

If the window is big enough, they can all be active at the same time. I prefer keeping them the same color.

Ah, okay. I didn't realize that because my screen isn't big enough.

Contributor

pwhelan commented May 12, 2016

LateNight becomes superfluous without vertically stacked waveforms, IMHO.

Member

ywwg commented May 12, 2016

LateNight becomes superfluous without vertically stacked waveforms, IMHO.
Show all checks

yes that's the primary reason LateNight exists

Contributor

pwhelan commented May 12, 2016

sorry... didn't see the waveforms in the middle, got confused with the track info boxes.

rryan added the skins label

Member

ronso0 commented Oct 1, 2017 •

edited

Loading

@ferranpujolcamins @ywwg @Be-ing

This PR seems to have fallen asleep.
From what I've heard, LateNight might get dropped in 2.1 due to the now historic effects section.
I'd like to make it ready for 2.1 by designing a the new effect section, therefor I'd adopt the LateNight part of this branch.
From the discussion I read that there are no major issues left and this is basically ready to merge and discussion about further tweaks can be continued in #923 ?

I started a discussion PR #1357

ronso0 mentioned this pull request

LateNight 2.1 #1357

Merged

Member

daschuer commented Oct 2, 2017

A mergeable version can be found here:
ferranpujolcamins#3

Member

daschuer commented Oct 2, 2017

I think a remaining issue here is if wee need crossfader assignment buttons for the decks.
At least for two deck Shade skin they are not helpful and I am in doubt that this will work without confusion in the other skins. The rest looks good for me.

Member

ronso0 commented Oct 2, 2017

A mergeable version can be found here:

Thanks! Though I'd really only take care of the skin, don't want to mess with keyboard shortcuts, menus and stuff.

I think a remaining issue here is if wee need crossfader assignment buttons for the decks.

They would complicate 2-decks mode, but I suppose they are expected in 4-decks mode, so it would make sense to show them for decks 3 & 4 only.

Member

daschuer commented Oct 3, 2017

In addition to the LateNight changes, this PR adds some items to the View menu and removes the individual spinny switching. New are:

New are:

Show 4 Decks "[Master]", "show_4decks"
Show Library "[Library]", "show_library"
Show Spinning Vinyl "[Spinny]", "show_spinnies"
Show Mixer "[Master]", "show_mixer"
Show Eqs "[Master]", "show_eqs
Show Crossfader "[Master]", "show_xfader"

I like the idea to have the view menu more complete.
Is this a good setup for the 2.1 view menu?
If Yes, I think we can merge this.

Contributor

Be-ing commented Oct 3, 2017

I like the idea to have the view menu more complete.

The View menu is redundant with the skin settings menu but it is not accessible in full screen mode.

Member

daschuer commented Oct 3, 2017

I like the idea to have the view menu more complete.

The View menu is redundant with the skin settings menu but it is not accessible in full screen mode.

What do you propose?

The menu is accessible in full screen mode on my Ubuntu and should be accessible on the other OSs as well. On which OS is it broken?

The redundant menu is a general question, we are IMHO not making things worse, if we add common skin settings to it as well.

Member

ronso0 commented Oct 3, 2017

The redundant menu is a general question, we are IMHO not making things worse, if we add common skin settings to it as well.

I agree, rarely used options can go to the View menu. But toggles for sub-menus -or button sets- like vinyl controls or beat grid buttons should stay in the skin. On the other hand, when there's a skin menu like Tango and Deere it (or the skin itself) should contain all options so users can be sure to find all options there.

Member

ronso0 commented Oct 11, 2017

The View menu is ... not accessible in full screen mode

On Xubuntu (Ubuntu Studio 14.04, xfce 4.10) it works well.
On Ubuntu 14.04 the menu bar is not when "Start in full screen mode" is enabled. If I toggle full screen off and on again, menu bar appears.

Contributor Author

ferranpujolcamins commented Dec 31, 2017

Can we close this after #1357 ?
@ronso0 @daschuer Is this something in this branch still relevant? I've just starting reading mixxx mails again and I'm a little bit lost.

ferranpujolcamins mentioned this pull request

Skin layout revamp resolved conflicts ferranpujolcamins/mixxx#3

Closed

Member

ronso0 commented Dec 31, 2017

@ferranpujolcamins
Yep, this can be closed.
Here you also proposed some changes to the menu bar, but I think those are not relevant anymore since we try to make the menu bar obsolete by moving many GUI toggles inside the skin, either into menus or a row of quick toggles.
Thanks for your work tough, we could use a lot of it! LateNight finally arrived in 2.1 and it feels good :)

Contributor Author

ferranpujolcamins commented Dec 31, 2017 •

edited

Loading

Superseded by #1357

@ronso0 Thank you for taking care of LateNight!!!!

ferranpujolcamins closed this

Contributor

poelzi commented Dec 31, 2017 via email

As long as the menu can be switched back on I'm fine with that. The menu has advantages as well. Especially for handycaped I think they are useful and casual users may find them more confident. Kind regards Poelzi

On 31 December 2017 18:20:53 CET, ronso0 ***@***.***> wrote: @ferranpujolcamins Yep, this can be closed. Here you also proposed some changes to the menu bar, but I think those are not relevant anymore since we try to make the menu bar obsolete by moving many GUI toggles inside the skin, either into menus or a row of quick toggles. Thanks for your work tough, we could use a lot of it! LateNight finally arrived in 2.1 and it feels good :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #913 (comment)

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

Contributor

Be-ing commented Jan 1, 2018

The discussion about the menu bar is getting quite off topic from this pull request. Let's continue the discussion on the Launchpad issue or start a new topic in the #development stream on Zulip.

ferranpujolcamins deleted the skin-layout-revamp branch

May 14, 2019 16:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels