Skin layout revamp dev #639
Conversation
New SoundSource/AudioSource API
…onBuild Fix Windows build (SoundSourceMediaFoundation)
mp3: Workaround for different sample rates in on file
SoundSourceProxyTest.seekForward was failing on OSX due to cover-test.mp3 not producing accurate samples on a seek. It seems this is related to the MP3 decoder not being "primed" right after a seek. To compensate for this, we seek backwards 29 MP3 frames (same as in SoundSourceMp3) and read forward. The test passes now but it would be ideal if we had a reliable way to determine the right amount to read on a per-file basis from ExtAudioFile directly (in case other formats need pre-fetching). I'm following up with Apple support for help here.
Add "stabilization read" to MP3 seeks in SoundSourceCoreAudio.
The decoding functions do NOT return the actual error code!! Instead the error code must be read from mad_stream if the decoding functions returned != 0. This caused some really ugly sounds at the beginning of some MP3 files, because frames were not skipped as suppossed to be.
Slightly more code, but hopefully easier to understand.
MP3 channel and decoding fix
*** CID 61970: Uninitialized members (UNINIT_CTOR)
/src/sources/soundsourcesndfile.cpp: 17 in Mixxx::SoundSourceSndFile::SoundSourceSndFile(QUrl)()
11 return list;
12 }
13
14 SoundSourceSndFile::SoundSourceSndFile(QUrl url)
15 : SoundSource(url),
16 m_pSndFile(NULL) {
>>> CID 61970: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member field "m_sfInfo.seekable" is not initialized in this constructor nor in any functions that it calls.
17 }
18
19 SoundSourceSndFile::~SoundSourceSndFile() {
20 close();
21 }
*** CID 61968: Uninitialized members (UNINIT_CTOR)
/src/sources/soundsourcemp3.cpp: 163 in Mixxx::SoundSourceMp3::SoundSourceMp3(QUrl)()
157 m_fileSize(0),
158 m_pFileData(NULL),
159 m_avgSeekFrameCount(0),
160 m_curFrameIndex(kFrameIndexMin),
161 m_madSynthCount(0) {
162 m_seekFrameList.reserve(kSeekFrameListCapacity);
>>> CID 61968: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member field "m_madSynth.pcm" is not initialized in this constructor nor in any functions that it calls.
163 }
164
165 SoundSourceMp3::~SoundSourceMp3() {
166 close();
167 }
…undSources Fix coverity warnings for new SoundSources
I think this set of improvements is fine for this PR. we don't have to solve all the problems now |
This seems like it could be a good idea to unify the effects UI. The variability between skins now is awfully confusing and unintuitive and puts controller mappers in an awkward situation. |
Conflicts: res/skins/LateNight/mixer.xml
|
I've just merged 1.12.
It's a workaround for another bug (worse in my opinion). As I commented before: <<<
I like it in the center :) |
|
Oh, I've just thought I could change the color or the "L" and "R" of the crossfader assign button to red and blue, it's a quick fix. The user could see at a glance where is a deck assigned. Would you like that? |
|
Another possible quick fix: can I get rid of the striped backgrounds on the decks and samplers? I don't really like them . |
leave that alone for now, we use red and blue for deck 1/2 vs 3/4 so it would be confusing to also use red/blue for right/left. Or just make both the R and L yellow text -- there's no real need to color code. Please put it back so the library button is not clickable -- it makes more sense than to have the button be broken. Or figure out a way to skin it so it is always on but has a "disabled" (unclickable) appearance. Like, flat with grayer text. |
I can do that we will still have the same problem with the view menu check option. I think this can't completely be solved until we have a way to communicate to Mixxx which CO a skin offers. |
|
how is it that in Deere, the menu items are grayed out?
no thanks :). Maybe in the future I'll change my mind but let's leave them for now. |
|
On a skin reload, mixxx.cpp checks which of these CO are declared by the skin. It was already this way. |
|
How is progress on this? |
|
Hi, I think the only thing that still needs to be done is this:
I'll try to fix this tomorrow. |
|
Done. What else is blocking this? |
|
Could you make the crossfader assignment CO persistent? As an example use case, I may want to keep decks 1 & 2 assigned to left and right, but not assign 3 & 4 to the crossfader. This would allow me to use the crossfader and two channel faders on my controller without getting confused when toggling between decks 1/3 and 2/4. |
|
I am opposed to merging this until https://bugs.launchpad.net/mixxx/+bug/1462061 is fixed. Without the ability to hide the library, that bug can't be worked around. |
|
This is still a bit too tall for my screen 1366x768 laptop screen. The bottoms of the buttons on the bottom bar are cut off by my panel when not in fullscreen mode. |
|
Hi @Be-ing , Shrinking the height of LateNight is yet another thing I'm planning to do. |
|
What is current state of this? I am afraid the git branch is messed up since there are unrelated commits listed, and it is not in a merge-able state. Is it still a 1.12 candidate? |
No, let's keep this master-only. I think LateNight is in fine shape for 1.12. |
|
(to be specific, the code changes and changes to other skins required by this alteration, coupled with the "nice-to-have" nature of the changes tip it in my mind to something for master. Although the height issue in latenight is annoying, it's not really a blocker) |
|
In fact this doesn't solve the issue of LateNight being too tall anyway. We still need to make a lot of work in order to offer the user a complete This is going to be long, so let's just take a compromise on each of the 2015-08-03 14:46 GMT+02:00 Owen Williams [email protected]:
|
|
@ferranpujolcamins, are you planning on finishing this PR for 2.1? |
|
Sure, I have some free days. I'll take a look.
|
|
Well, actually not. Sorry. 2016-01-19 8:22 GMT+01:00 Ferran Pujol Camins [email protected]:
|
|
Superseded by #913, which merges to master cleanly. |
Summary of changes:
-Removed the layout option buttons of the top of LateNight
-Added layout options to view menu. Rearranged view menu.
-Added the option to hide the crossfader to LateNight and Shade
-Modified LateNight so that the library cannot be hidden when the skin is in medium or full size.