Mouse vanish bug fix #4744
Merged
Mouse vanish bug fix #4744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be a workaround for the missing cursor, that happens on MacOS probably due to a missing release event in overload situations. lp196978 If this happens again, only one knob is affected instead of whole Mixxx and it heals itself by another mouse click because it is not longer stacking up.
uklotzde
reviewed
May 8, 2022
src/util/scopedoverridecursor.h
Outdated
| QApplication::setOverrideCursor(cursor); | ||
| QApplication::processEvents(); | ||
| QGuiApplication::setOverrideCursor(cursor); | ||
| QGuiApplication::processEvents(); |
There was a problem hiding this comment.
QCoreApplication::processEvents()?
There should be a compiler or linter flag for detecting these kinds of inconsistencies.
There was a problem hiding this comment.
I have added this to the last commit.
uklotzde
approved these changes
May 10, 2022
This was referenced Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix bugs:
https://bugs.launchpad.net/mixxx/+bug/1130794
https://bugs.launchpad.net/mixxx/+bug/1969278
It replace using to global cursor stack by using the widget cursor.
This should be a workaround for the missing cursor on MacOS, probably due to a missing release event in overload situations. If this happens again, only one knob is affected instead of whole Mixxx and it heals itself by another mouse click because it is not longer stacking up.