Unrevert "Create wmainmenubar controls in coreservices so they are available to controllers on startup" #4661
Conversation
…are available to controllers on startup""
|
|
||
| m_uiControls.reserve(uiKeys.size()); | ||
| for (const auto& key : uiKeys) { | ||
| m_uiControls.emplace_back(std::make_unique<ControlPushButton>( |
There was a problem hiding this comment.
persist = true already fetches the last value from the config.
The default value is used as a default if there is not yet anything stored.
Line 65 in c7b4dbb
There was a problem hiding this comment.
Hm, does that mean we need to pick the first-run defaults here? Seems so
|
Tested first-run case by moving ~/.mixxx aside, looks good |
| {ConfigKey(VINYL_PREF_KEY, "show_vinylcontrol"), true, false}, | ||
| {ConfigKey("[PreviewDeck]", "show_previewdeck"), true, true}, | ||
| {ConfigKey("[Library]", "show_coverart"), true, true}, | ||
| {ConfigKey("[Master]", "maximize_library"), true, false}, |
There was a problem hiding this comment.
| {ConfigKey("[Master]", "maximize_library"), true, false}, | |
| {ConfigKey("[Master]", "maximize_library"), false, false}, |
This is not persistent with official skins anyway.
| {ConfigKey("[Master]", "skin_settings"), false, false}, | ||
| {ConfigKey("[Microphone]", "show_microphone"), true, true}, | ||
| {ConfigKey(VINYL_PREF_KEY, "show_vinylcontrol"), true, false}, | ||
| {ConfigKey("[PreviewDeck]", "show_previewdeck"), true, true}, |
There was a problem hiding this comment.
| {ConfigKey("[PreviewDeck]", "show_previewdeck"), true, true}, | |
| {ConfigKey("[PreviewDeck]", "show_previewdeck"), true, false}, |
hidden by default in all official skins.
Do we need to change that?
| }; | ||
| const std::vector<UIControlConfig> uiControls = { | ||
| {ConfigKey("[Master]", "skin_settings"), false, false}, | ||
| {ConfigKey("[Microphone]", "show_microphone"), true, true}, |
There was a problem hiding this comment.
| {ConfigKey("[Microphone]", "show_microphone"), true, true}, | |
| {ConfigKey("[Microphone]", "show_microphone"), true, false}, |
| {ConfigKey("[PreviewDeck]", "show_previewdeck"), true, true}, | ||
| {ConfigKey("[Library]", "show_coverart"), true, true}, | ||
| {ConfigKey("[Master]", "maximize_library"), true, false}, | ||
| {ConfigKey("[Samplers]", "show_samplers"), true, true}, |
There was a problem hiding this comment.
Hidden by default, shown in Deere.
Should we unify that to visible? (maybe) Edit Nope: Shade always shows the samplers play buttons in the decks row, 'show_samplers' would toggle the samplers row below the decks. Though other skins could show the
If so, do we need a menu bar button?
If we add this and 'Show Effect Rack' the View menu would be complete, wouldn't it?
|
Ha! A few minutes too late... |
|
Oh Sorry. It could be a nice GitHub feature to see if there are unpublished reviews ... |
|
I could have sel-requested a review, but I only announced it in Zulip. Anyway, we can discuss my review comments and based on the outcome I can open a follow-up PR. |
Reverts #4660,
Includes fix