control object creation order broken in main branch: cos created by skin not available to controller scripts

[mixxxbot]

Reported by: ywwg
Date: 2021-02-08T00:16:51Z
Status: Confirmed
Importance: High
Launchpad Issue: lp1914969

---

My traktor s3 script stopped loading correctly in main. I see this:

Warning [Controller] ControlDoublePrivate::getControl returning NULL for ( "[Channel1]" , "end_of_track" )
Warning [Controller] ControllerScriptHandlerBase: "Uncaught exception at line 1729 in file file:///home/owen/src/github/mixxx/res/controllers/Traktor-Kontrol-S3-hid-scripts.js.\n\nException:\n  Error: script tried to connect to ControlObject ([Channel1], end_of_track) which is non-existent."

Other times the control it barfs on is Master / maximize_library.

Both of these control objects do exist, but are not created until the skin parsing code comes across them and then creates them on the fly. It looks like something happened in the startup ordering to break this. I am doing a git bisect to see if I can locate the change.

[mixxxbot]

Commented by: Be-ing
Date: 2021-02-08T00:28:19Z

---

Likely a regression from #3446

[mixxxbot]

Commented by: ywwg
Date: 2021-02-08T02:22:34Z

---

I don't think that pull request is necessarily wrong. maximize_library is referenced in main code, but isn't ever created there. The main menubar could own it, for instance. There may be other GUI actions we'd like to make available and should have explicit COs, like show_mixer / show_vinylcontrol / show_coverart

[mixxxbot]

Commented by: ronso0
Date: 2021-02-08T19:35:23Z

---

my Terminalmix mappings fail when trying to connect LEDs to ..,show_mixer, show_4decks and other essential skin COs

[mixxxbot]

Commented by: Holzhaus
Date: 2022-01-12T23:25:38Z

---

I'm setting this to high. We should make these COs either first-class Mixxx COs that always work, or remove them from all builtin mappings.

At the moment, all mappings that use one of these COs are unusable with skins that donvt support them and won't work in QML mode either.

[daschuer]

@ywwg Is this still open?

[ronso0]

Finally fixed by #4661, no?

[daschuer]

Ok let's assume this is fixed. Please re-ooennif we have still issues.