Require TagLib 1.11 or newer #4251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be-ing
reviewed
Aug 28, 2021
|
Ubuntu 20.04 ships TagLib 1.11.1. To maintain adherence to our minimum requirements policy we need to either:
|
|
Disregard the last comment. I mistakenly thought TagLib 1.12 was required. |
|
This PR does not conflict with the minimum requirements policy. We only require TagLib 1.11.x here. This version has serious, known bugs (e.g. OGG corruption) and we still maintain workarounds. |
Be-ing
approved these changes
Aug 28, 2021
|
+38 −228 :) |
|
Why does the build fail on Windows? We package version 1.12. |
|
Are you sure the current Windows build environment has TagLib 1.12? This might need to wait for #4225. |
|
Oh I think it is an issue with the version detection. |
On Windows, the pkgconfig file is found and the variable is defined but somehow set to empty string.
|
I fixed the version detection on Windows: https://github.com/uklotzde/mixxx/pull/18 |
CMake: fix version detection for TagLib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...to get rid of untested legacy code.
Do we need a redundant check in CMakeLists.txt in addition to the
static_assertin the code? I have left a TODO comment.This might also fix https://bugs.launchpad.net/bugs/1940777: The invocation of
SoundSource::importTrackMetadataAndCoverImage()inSoundSourceOpus::importTrackMetadataAndCoverImage()was accepted by all compilers even though this is slightly misleading. It should have beenMetadataSource::importTrackMetadataAndCoverImage().