Auto dj crates #18
Merged
Auto dj crates #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I need some feedback on the GUI, but otherwise this feature should be ready for merging into the trunk!
…d, and uses that to prioritize randomly-added tracks! I thought the system didn't have that info...turns out it's stored as PlaylistTracks.pl_datetime_added for set-log playlists! Also updated to latest trunk version.
…o DJ" feature. One more convenient way to add a crate to the auto-DJ queue!
…te from AutoDJ" to "Disconnect from AutoDJ", and fixed curly-brace placement, per Daniel Schürmann's feedback.
…s of how recently the track was played.
Added one word to auto-DJ-crates preferences text
Conflicts: mixxx/res/schema.xml mixxx/src/dlgprefcontrols.cpp mixxx/src/library/trackcollection.cpp
| @@ -347,4 +347,12 @@ METADATA | |||
| ALTER TABLE Library ADD COLUMN key_id INTEGER DEFAULT 0; | |||
| </sql> | |||
| </revision> | |||
| <revision version="19" min_compatible="3"> | |||
There was a problem hiding this comment.
This is now outdated (v19 is taken).
There was a problem hiding this comment.
This, as well as the formatting issues and goto usage, have been taken care of.
Please let me know if there's anything else preventing this pull request from being merged.
|
Remaining issues: We should improve the Ignore time flag presentation. We should also unify the Gui text, the config Key names and the variables "ActivePercentage" vs "Minimum Available". |
| void DlgAutoDJ::enableRandomButton(bool a_bEnabled) | ||
| { | ||
| #ifdef __AUTODJCRATES__ | ||
| pushButtonAddRandom->setEnabled (a_bEnabled); |
There was a problem hiding this comment.
Please remove spaces between function and arguments list (here and elsewhere).
Conflicts: src/library/cratefeature.cpp src/library/dao/cratedao.cpp
checkable; Removed .arg() chains.
PlayerInfo. Removed unusual prefix from some parameters.
ghost
assigned 
Conflicts: build/features.py
Closed
Merged
gramanas
pushed a commit
to gramanas/mixxx
that referenced
this pull request
Jun 7, 2017
Fix some coding issues
Be-ing
added a commit
that referenced
this pull request
Apr 3, 2018
…ehavior use isAdoptMetaknobValueEnabled and "[Effects]", "AdoptMetaknobValue"
11 tasks
Be-ing
pushed a commit
that referenced
this pull request
Aug 28, 2021
CMake: fix version detection for TagLib
This was referenced Aug 22, 2022
m0dB
pushed a commit
to m0dB/mixxx
that referenced
this pull request
Jan 21, 2024
replace IRC with Zulip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the transfer of the Launchpad merge request:
https://code.launchpad.net/~ulatekh/mixxx/auto-dj-crates/+merge/164061