Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libarycontrol: backport of #3198: fix crash when trying to refocus th… #3201

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Oct 22, 2020

…e library while another Mixxx window has focus

Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some minor remarks.

src/library/librarycontrol.cpp Outdated Show resolved Hide resolved
src/library/librarycontrol.cpp Outdated Show resolved Hide resolved
…ocus the library while another Mixxx window has focus
@Holzhaus Holzhaus marked this pull request as draft October 24, 2020 12:49
@ronso0 ronso0 marked this pull request as ready for review October 27, 2020 17:11
@ronso0
Copy link
Member Author

ronso0 commented Oct 27, 2020

@uklotzde Please have another look.

Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. CI failures are unrelated. Thank you! LGTM

@uklotzde uklotzde merged commit 9061511 into mixxxdj:2.2 Oct 29, 2020
@ronso0 ronso0 deleted the libnavi-crash2.2 branch October 29, 2020 15:11
@Holzhaus
Copy link
Member

@ronso0 Can you add a changelog entry?

@ronso0
Copy link
Member Author

ronso0 commented Oct 29, 2020

Is there a reason we use the [link](url:sfddsf/html) syntax in 2.3 only?

@Holzhaus
Copy link
Member

Yes. In 2.2 the changelog is not a markdown file.

ronso0 added a commit to ronso0/mixxx that referenced this pull request Oct 29, 2020
uklotzde added a commit that referenced this pull request Oct 29, 2020
@uklotzde uklotzde modified the milestones: 2.2.5, 2.3.0 May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants