Libarycontrol: fix crash when trying to refocus the library #3198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daschuer
approved these changes
Oct 21, 2020
|
It looks like Mixxx 2.2 is also affected. If this is the case, can you backport this fix to 2.2? |
|
Sure, but I'd rely on CI and manual testing by others then because I recently failed to re-enact scons :\ and I don't wanna spend time with that anymore. |
ronso0
added a commit
to ronso0/mixxx
that referenced
this pull request
Oct 22, 2020
…ocus the library while another Mixxx window has focus
|
Do we need this separate fix for 2.3 or could the fix for 2.2 in #3201 be merged into 2.3 and main without major conflicts? |
|
There will be conflicts I suppose. |
ronso0
added a commit
to ronso0/mixxx
that referenced
this pull request
Oct 27, 2020
…ocus the library while another Mixxx window has focus
uklotzde
added a commit
that referenced
this pull request
Oct 29, 2020
Libarycontrol: backport of #3198: fix crash when trying to refocus th…
|
Please rebase on 2.3 now. |
…ther Mixxx window has focus
|
do we need a changelog entry for this as well? |
|
ding dong! @uklotzde |
|
We already a changelog entry from #3201. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Mixxx crashes when trying to refocus the library while another Mixxx window has focus.
I experienced this while DlgCoverArtFullSize had focus.