Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 2.3 beta #2697

Merged
merged 14 commits into from
May 12, 2020
Merged

release 2.3 beta #2697

merged 14 commits into from
May 12, 2020

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Apr 22, 2020

This CHANGELOG is YUGE! Amazing job, everyone!

@Be-ing
Copy link
Contributor Author

Be-ing commented Apr 22, 2020

Please comment if I missed anything and link the PR in your comment.

@Holzhaus
Copy link
Member

What about CHANGELOG.md?

@Be-ing
Copy link
Contributor Author

Be-ing commented Apr 22, 2020

I didn't realize CHANGELOG.md existed. I don't think we should have both. Let's pick one. I don't really care which.

CHANGELOG Outdated Show resolved Hide resolved
@Swiftb0y
Copy link
Member

Are these strictly just relevant for the end-user ? There are #2032, #2054 and #2054 which are only relevant for mapping devs.

@daschuer
Copy link
Member

Thank you. Before the beta release I like to update the contributor list.

@Be-ing
Copy link
Contributor Author

Be-ing commented Apr 22, 2020

Thank you. Before the beta release I like to update the contributor list.

I would appreciate if you took care of that, thanks.

@ywwg
Copy link
Member

ywwg commented Apr 22, 2020

I didn't realize CHANGELOG.md existed. I don't think we should have both. Let's pick one. I don't really care which.

I think changelog.md is the more modern option (does github pay attention to it?). That's the one I'd like to stick with.

@ywwg
Copy link
Member

ywwg commented Apr 22, 2020

Are these strictly just relevant for the end-user ? There are #2032, #2054 and #2054 which are only relevant for mapping devs.

the changelog tries to cover most of the major changes including those that aren't relevant to end users.

CHANGELOG Outdated Show resolved Hide resolved
@Swiftb0y
Copy link
Member

the changelog tries to cover most of the major changes including those that aren't relevant to end users.

Great. So #2032, #2054 and #2054 should be included in the changelog then I guess (which they aren't currently).

@Holzhaus
Copy link
Member

#2054 and #2054 should be included in the changelog

2020_04_23_123158

@Be-ing Be-ing force-pushed the 2.3_beta branch 4 times, most recently from 7d9f56f to 1b0411c Compare April 23, 2020 00:04
@Be-ing
Copy link
Contributor Author

Be-ing commented Apr 23, 2020

I linked to all the PRs in the Markdown document. Doing this in Markdown will make it very easy to copy to the website blog post.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@Swiftb0y
Copy link
Member

Oh, my bad. I meant #2032, #2052 and #2054.

@Holzhaus Holzhaus added this to the 2.3.0 milestone Apr 23, 2020
@daschuer
Copy link
Member

The contributor list is updated:
#2704

* Show track context menu when right clicking text in decks [#2612](https://github.com/mixxxdj/mixxx/pull/2612) [#2675](https://github.com/mixxxdj/mixxx/pull/2675) [#2684](https://github.com/mixxxdj/mixxx/pull/2684) [#2696](https://github.com/mixxxdj/mixxx/pull/2696)
* Add laptop battery widget to skins [#2283](https://github.com/mixxxdj/mixxx/pull/2283) [#2277](https://github.com/mixxxdj/mixxx/pull/2277) [#2250](https://github.com/mixxxdj/mixxx/pull/2250) [#2228](https://github.com/mixxxdj/mixxx/pull/2228) [#2221](https://github.com/mixxxdj/mixxx/pull/2221) [#2163](https://github.com/mixxxdj/mixxx/pull/2163) [#2160](https://github.com/mixxxdj/mixxx/pull/2160) [#2147](https://github.com/mixxxdj/mixxx/pull/2147) [#2281](https://github.com/mixxxdj/mixxx/pull/2281) [#2319](https://github.com/mixxxdj/mixxx/pull/2319) [#2287](https://github.com/mixxxdj/mixxx/pull/2287)
* Show when passthrough mode is active on overview waveforms [#2616](https://github.com/mixxxdj/mixxx/pull/2616)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Add "Help" button to preferences dialog that opens the corresponding manual section in a web browser. [#2716](https://github.com/mixxxdj/mixxx/pull/2716)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that really need to be mentioned in the changelog?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a user-visible change... why not?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's a small change and this changelog is already a lot to read.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated
* Note: The first Rekordbox memory cue is imported for the main cue button in Mixxx and the remaining Rekordbox memory cues are imported as Mixxx hotcues, starting with the next hotcue number after the last hotcue from Rekordbox.
* Import cue points, track colors, one loop and playlists from Serato file tags & database [#2480](https://github.com/mixxxdj/mixxx/pull/2480) [#2526](https://github.com/mixxxdj/mixxx/pull/2526) [#2499](https://github.com/mixxxdj/mixxx/pull/2499) [#2495](https://github.com/mixxxdj/mixxx/pull/2495)

* Note: Mixxx does not yet support multiple loops per track. We are working on this for Mixxx 2.4. In Mixxx 2.3, if you import a track with multiple loops from Rekordbox or Serato, only the first loop will be imported.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this hint also go to the Rekordbox root view?
If the feature looks like in 2.2 users familiar with the workflow won't read the changelog, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved it above both the Rekordbox and Serato bullet points. Does that work?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?
I was trying to say: those notes should probably also be in the root view of those features in the Library.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good idea. Want to make it happen?

@Be-ing Be-ing changed the base branch from master to 2.3 May 7, 2020 12:47
@Be-ing
Copy link
Contributor Author

Be-ing commented May 9, 2020

Ready for merge?

@Be-ing
Copy link
Contributor Author

Be-ing commented May 10, 2020

ping

@Holzhaus
Copy link
Member

Holzhaus commented May 12, 2020

There are conflicts now. I don't know when the beta release will be possible due to the build server issue, but it makes sense to merge the changelog soon to avoid further conflicts. Should we postpone the version bump in version.h and merge this PR without it for now?

@daschuer
Copy link
Member

No need to revert the version.
Beta can start now without the build server.

@daschuer
Copy link
Member

It has already started IMHO when cutting the branch.

@Be-ing
Copy link
Contributor Author

Be-ing commented May 12, 2020

Okay, I'll merge this then. I am tired of dealing with the merge conflicts in the CHANGELOG.

@Be-ing Be-ing merged commit e60a749 into mixxxdj:2.3 May 12, 2020
@Be-ing Be-ing deleted the 2.3_beta branch May 12, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants