Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Velocity sensitive ComponentsJS SamplerButtons #2032

Merged
merged 2 commits into from
Feb 23, 2019
Merged

Velocity sensitive ComponentsJS SamplerButtons #2032

merged 2 commits into from
Feb 23, 2019

Conversation

Swiftb0y
Copy link
Member

@Swiftb0y Swiftb0y commented Feb 16, 2019 •
edited
Loading

You can now add velocity: true, while creating a SamplerButton. This will set the channel volume of the sampler accordingly when launched.

TODO:

  • Testing
  • Documenting

@daschuer
Copy link
Member

this looks like an interesting feature.
I think velocity: true is not self explaining.
how about
volumeByVelocity: true
or similar.

@Swiftb0y
Copy link
Member Author

how about velocitySensitive?

@daschuer
Copy link
Member

It is missing that the "volume" is effected

@daschuer
Copy link
Member

LGTM @Be-ing anything else to consider before merge?

@Be-ing
Copy link
Contributor

Be-ing commented Feb 23, 2019

LGTM

@Be-ing Be-ing merged commit 30a4e7f into mixxxdj:master Feb 23, 2019
@Swiftb0y Swiftb0y mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Swiftb0y @daschuer @Be-ing