trigger double load clone from PlayerManager instead of BaseTrackPlayer #2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is arguably a better place to do it, and allows tests that rapidly load tracks to work properly.
|
Thanks for taking care of this. Good to see that the tests even reveal opportunities for design improvements. I can confirm that the tests are fixed, though I'm not familiar with the actual code and the desired functionality. |
|
Thank you for taking care of this. There was an unrelated test failure which I fixed in 46916ba. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is arguably a better place to do it, and allows tests that rapidly load tracks to work properly.
This fixes a lingering issue from #1892.