Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Mapping for the Numark N4 #1647

Closed
wants to merge 72 commits into from
Closed

New Mapping for the Numark N4 #1647

wants to merge 72 commits into from

Conversation

Swiftb0y
Copy link
Member

I wasn't able to write any documentation yet but the code works so far. While I'm confident that the mapping works well, it has not undergone any more extensive tests. The code looks a bit messy at some parts so please ask if something isn't clear.

daschuer and others added 30 commits December 29, 2017 03:43
properly update LICENCE and README.md for 2.2
Remove NSIS files as we now have completely switched to wix
This reverts commit 70b6c95.
lp1689014 : Fix crash when parsing bad xml controller file
When Fx button left is enabled, touchpad can be used to change FX1 rack
mix volume.

When Fx button right is enabled, touchpad can be used to change FX2
rack mix volume.
@uklotzde
Copy link
Contributor

Should this be distributed as an update for 2.1? Then please change the target branch from master to 2.1. Maybe you first need to rebase this branch or create a new branch on top of 2.1 that contains just the relevant commits.

What is the current status and who else is able to test this?

@Swiftb0y
Copy link
Member Author

I guess it could be included as an update for 2.1, but I'm quite familiar enough with git to know which commits are relevant in this case.
The mapping works so far but I have yet to complete the documentation.
As far as I know, the N4 was pretty popular back in the day but I don't know how many people still have one.

@Be-ing
Copy link
Contributor

Be-ing commented Apr 27, 2018

Thanks for taking care of this old controller. We do get people asking about it every once in a while. Please comment here when you have written the documentation. It is impractical for anyone who does not have the hardware to review the mapping without documentation.

@Swiftb0y
Copy link
Member Author

I'm working on the Wiki page as we speak. I already made a, for mixxx customized, vectorized version of the Overlay that comes for Serato/Traktor (listed on the wiki already).

@Swiftb0y Swiftb0y changed the base branch from master to 2.1 April 27, 2018 19:09
@Swiftb0y
Copy link
Member Author

Ill close this, merge 2.1 and PR it again to the 2.1 branch

@Swiftb0y Swiftb0y closed this Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants