lp1746325 : Fix empty deck can be played #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, Thank you very much! LGTM |
|
Whoops, I noticed this was targeted at the master branch. I rebased it on 2.1 for the release. |
ronso0
added a commit
to ronso0/mixxx
that referenced
this pull request
Jul 19, 2018
lp1746325 : Fix empty deck can be played
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : when a deck is empty (after ejecting or when loading a track failed), it is possible to play it.
Cause : Unloading a track is done by loading an empty track. This is a special case where the deck would enter a 'track loading' state without exiting it. A deck can be played when it is loading a track.
Fix : Do not consider a track is loading when it is an empty track.