-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unnecessary painting in CoverArtDelegate #13715
Conversation
FWIW I'm not noticing a difference in performance between 2.4 and this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small findings, I'll take a closer look soonish.
The actual but small speed up happens once you stop scrolling. In this case the cover pictures appears faster. In the original version the uni-color replacements are first painted again after scroll stop and than the original covers are fetched and pained. The other optimizations has only a negligible speed up. In 2.4 the chache grows up to 1000 and more, which requires repeated memory allocations. This branch reuses the memory once it is allocated for the number of all visible rows. |
Co-authored-by: ronso0 <[email protected]>
Done |
Co-authored-by: ronso0 <[email protected]>
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but let's polish that comment
Co-authored-by: ronso0 <[email protected]>
Done |
Thank you! |
I have created this during my my first attempt to fix the priority inversion #11128 when scrolling with cover arts column enabled. This is a bit of a speed up, but does not fix the actual problem. This will be part of the next PR #13719