Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading cover art while scrolling locks up the GUI, preventing further scrolling until the cover art is loaded #11128

Open
robbert-vdh opened this issue Dec 15, 2022 · 5 comments

Comments

@robbert-vdh
Copy link
Contributor

Bug Description

I already asked about this in Zulip, but I realized I should probably create a bug report so it doesn't get lost. When the cover art column is visible and you scroll through the tracks list, any time the placeholders are being replaced by the actual cover art images fetched from the audio files the UI completely freezes for a short amount of time. The time this takes likely depends on the store the media is stored on, and depending on how the parsing works maybe also on the file size and file type. Loading all media from (relatively fast) mechanical storage, I've seen these hickups last from a hundred milliseconds all the way to almost a second. If you continuously scroll up or downwards then the issue likely either won't appear because you're scrolling fast enough that the placeholders are never replaced, or slow enough that only a couple placeholders are replaced at a time. The issue is most noticeable when scrolling several pages at a time using a traditional mouse scroll wheel. I'd attach a screencast but It's difficult to visualize the delay without doing the scrolling yourself.

Version

main branch, 3aa2318

OS

Arch Linux

@daschuer
Copy link
Member

We had a similar bug:
#10223

"Fixed" here: #4904
Maybe there is something else blocking.

@robbert-vdh
Copy link
Contributor Author

Yeah it still happens on the current main branch. I have to hide the cover art column to be able to comfortably scroll through my library.

@ronso0
Copy link
Member

ronso0 commented Dec 16, 2022

@robbert-vdh
I remember a bug where the aspect ratio of the cover was relevant (width of column).
Can you rule that out?

@robbert-vdh
Copy link
Contributor Author

@ronso0 As in, the aspect ratio of the actual column, not the cover art itself? By default Mixxx makes the column to a pretty wide aspect ratio for me if the column is already visible when Mixxx is loaded:
image

If I disable the column, completely restart Mixxx, and re-enable it the column defaults to a square aspect ratio like you'd expect:

image

There however doesn't seem to be any difference in performance between the two sizes and other wider aspect ratios. I'm having over half second pauses scrolling through my library, and if I use the big library mode it takes well over a second before I can continue scrolling.

@mxmilkiib
Copy link
Contributor

mxmilkiib commented Jan 27, 2024

I'm getting this with 2.5-alpha.

It's about the most obvious and frustrating bug Mixxx has imo.
(The other one probably doing anything whilst Analysing, which is of a similar essence)

My music and art is accessed via NAS.

@daschuer daschuer added this to the 2.4.1 milestone Jan 27, 2024
@daschuer daschuer modified the milestones: 2.4.1, 2.4.2 Apr 14, 2024
daschuer added a commit to daschuer/mixxx that referenced this issue Oct 4, 2024
…adata. This fixes a priority inversion when scrolling the library mixxxdj#11128
daschuer added a commit to daschuer/mixxx that referenced this issue Oct 4, 2024
…adata. This fixes a priority inversion when scrolling the library mixxxdj#11128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants