-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tango skin #1151
Tango skin #1151
Conversation
I see the forum link, but just to keep everything inside github can you attach a screenshot or two with the most recent look to this PR? |
I'll test this later (likely tomorrow), but a few things jump out to me from the screenshots:
|
This skin is a candidate for small skins, but the minimum size is bigger than my 1366 x 768 screen. |
The gap between the two effect regions is moving and resizing depending on the effect. It would be nice to have it fixed. |
Wow, it is a lot of fun to play with this skin. Thank you ! |
Thanks for the feedback so far! Added screenshots and the most recent version as .zip
Indeed. 'FlatOne' is my new favourite.
I played around with that already, am not happy yet either. Testing will be much easier if I find a way to make use of #302 i.e. for the spinny masks.
On my list ;) like the JS Effects mapping...
Until now it was 1010px min-width, now it's 1270). I designed it @ 1366x768, so something is squeezed?
If there's a need, I will. In the forums there was also a request for a portrait mode for tablets. But it I'm afraid it would either a) become much more complex (the code, SizeAwareStacks for Deck buttons, Loop section etc.)
Fixed. The spacer in between now also adapts to other situations, and the Effect units only grow if 'graphical EQ' is selected on one side.
My pleasure! Initially built it for me, and if someone else has fun with it it's win-win-win! |
I like that name too.
The high is taller than 768. This makes my maximize windows button disappear. The width is much smaller then 1366. You have Portrait mode: Does this means to squeeze to 768 width? I would postpone this to an extra skin.
This mean just practising DJing at home. |
Shame on me, I didn't consider the menu bar (just window decoration) and didn't test properly. |
Updated zip |
Wow, thanks for your extensive review!
I'm reworking the lower half. Right now minimum size for Samplers/Library is 83px (Table header and about 3 lines), less than that would be a joke, I think.
Will fix that!
Seriously? Low contrast was one of the reasons I couldn't work with Deere. Sure they could be plain white but I'd like to hear another opinion on that.
Agree. There could be an 'expand' button, exactly like for vinyl options & extra deck buttons.
It would be cool to have a one-line HotCue label widget like that. Where you could edit HotCue labels on click, without going to Library, then to comments, then editing the comments.
Agreed. Like with Samplers and Decks' HotCues
Big CoverArt/Spinny where the channel mixer is or small version in the overview waveform. You'll sure see the difference when you hide the mixer -_o
Agree...
...and disagree vehemently! When you normally use a minimal view without scrolling waveforms and other annoying stuff (what I actually made this skin for), these are the most important buttons in the skin!
Yeah, didn't find a proper solution to that yet, without squeezing the clock/buttons. In one version I put the crossfader on top of the logo, with a fading slider scale. Other suggestions?
Hm...I was actually trying to make button texts obsolete in general by using explicit icons. I think the hamburger menu icon is somehow an established one since all that smartphone apps, and it's placed quite prominent.
What you mean? |
Edited PR description. I'm curious how this skin looks on screens other tha 1366x768. Anyone? |
I don't think that bug has to do with the minimum height.
I think the issue is that the notches blend in with the colors of the rest of the skin, not so much that they're hard to distinguish from the knob. The blue, red, and orange notches stand out much more.
It sure would, but a lot of work would have to be done on the C++ side for that to happen. There is a Launchpad blueprint for that.
Okay, we can disagree on that.
I was thinking that removing the top row of buttons might make room for both, but if you want to keep those I guess there would have to be a different solution. I realize that your intention is primarily for use with controllers. Personally, I like having the mixer shown on screen when I am using a controller so I don't have to look down at my controller to know where my knobs and sliders are set while focusing on something else on screen, like the waveforms or library.
I see now after looking at your screenshots that is the state it is always in. I find the asymmetry kinda odd. Is there a reason you made the decks asymmetrical like that? |
Okay, I did experience something like that when enabling 4 decks + waveforms + FX units, that's why I rework the lower half.
Coming from LateNight, I initially found it helpful to relate vertically ordered waveforms to horizontally ordered decks, background colors wouldn't help me much. But even now I get confused now and then anyways. If there's a standard like top waveform=left, bottom = right, I will stick to that. In Deere I find it not intuitive that waveforms of decks 3 & 4 would show up below and beneath those of of deck 1 & 2.
I agree that we disagree! :) Who said that? Earth would be so f***ing boring if we all had the same habits and taste. |
Next step will be to implement collapsible FX units, both for 2.0 (Effect names + SuperKnob) and 2.1 (Effect names + MetaKnobs). |
Also on collapsible FX units I need some help:
It's possible to get available space for everything below stacked waveforms, but I failed to achieve 3. |
I don't think you need to worry about this too much. The new effects UI is designed so the effect units can be in collapsed view most of the time.
I don't think the current skin system is smart enough to implement such complex behavior. This is the kind of thing that QML would be really helpful for. |
So -on small screens- some elements would need to hidden in order to configure FX units. Okay.
Any idea on this? |
Yeah. The expanded view is mostly meant for setting up effect chains, but there shouldn't be a need to keep it expanded while mixing.
I don't think so. I suggest making separate git branches. |
Next step is to implement collapsible FX units -both for 2.0 and 2.1- and more logic to avoid odd visual states on small screens. And I'll test how to make it fit 1024px. |
Nice work. IMO this is close to ready to merge for the beta. Improvements can continue to be merged during the beta period. Some more comments:
It's easier to keep track of changes if you split them into smaller commits. If you have a pile of changes you want to commit, you can use git's interactive features to selectively add different changes to different commits, then push them all together. Using a GUI git frontend program can help with that. Personally I like Git-Cola. |
I added a comment, but you just addressed it, so I'll try your suggested fix. |
Fixed in #1251 |
I thought I had already added this comment, but the + - buttons next to the loop presets don't do anything. Should they extend or shrink the loop size by 1 beat? |
👍 You discovered another 2.1 CO: loop_halve instead of beatloop_halve |
Regarding usability testing, I've used tango in production for 4 gigs, each lasting about 4 hours and everything worked great. The only usability issues I have are with the state of bit indicators. For example quantize is red when ON, but the other indicators like key lock are red when OFF. The other issue is it's cumbersome to get spinnies with album art and tape markers. The ui for that in the side menu is pretty confusing, and takes a few clicks to get it like I like it. Those settings never persist even though they should, but that might be a bug. |
Thanks for your feedback!
Actually it's just keylock that's not red when it's On. But yeah, there has been some discussion about this, can't find the comments...but it's in the ToDo in 1st post for a reaon -_o
What exactly do you find confusing?
It is indeed. Thanks for finding, didn't notice that since changing that option to a 3-state button. |
Agree with points above that following convention (on=colored, off=grey) is more intuitive. |
i like the little red magnet with the silver tips, it's a nice touch. That said, red in software almost always means danger. With keylock, grayed/off + some other color/on (green? blue?) etc would work for me. Gray always means OFF, regardless if that is the sane default. In fact, with software that is as user customizable as mixxx, there's really no default. Many DJs would argue that quantize is always bad, so their 'default' is off. Same with keylock. This is really just semantics, and if we changed our term to describe the control as 'Active' or 'Inactive', it almost fixes itself. What's normal for you isn't for me, so the slip mode being active (colored) or inactive(gray) becomes immediately intuitive. If there's another thread on this I'll be glad to reference this comment there as well. |
Okay, intuition wins. Keylock OFF will be grey and I'll try some colours for the ON state. Feels like a good moment to bring up the ToDo list and continue discussion here. Changes can be applied in a different PR. Do you think crossfader assignment button in decks is colourful enough? Correct font family/size in special nodes: are any texts like effect names, BPM or key displays are cropped/shifted on anyone’s OS? Do you feel that different overview background colours in decks are necessary at all? Does the Repeat button in samplers make sense? |
Yeah this might be a good point to start feature requests against the skin. I'd actually like to see the skins split into separate repos that PRs get done against, then get packaged with mixxx.
This is where it's probably starting to get very user specific, because for example, my controller (DDJ-SB2) has Keylock indicators, so I just look at my controller. Slip mode is good to know, so if I grab a jog wheel to scratch, it'd be good to be able to know and/or switch slip mode on. Same with crossfaders and mixer components. I turn all those off because I have a physical controller. Regarding samplers, I load name drops and intros into them right at startup (which get saved, yay), and use my sampler buttons on the controller. My preference vs an eject button is to just drag a new track or right click and add to the sampler, thereby replacing the one that may be there now. Never considered the need for repeat on samplers either, but a per sampler channel quantize would be good for drum samples. Re: overview colors. It's pretty intuitive to me which deck and track overview is which, so the colors don't bring much more information to the UI, so my preference would be to have the same colors but as high contrast as possible because i'm frequently searching the interface looking for the track remaining times. Symmetrical vs identical overviews I don't have an opinion on, but that might be a future feature to allow switching the deck overviews to a symmetrical layout (title&artist on outside, times near the center, etc). Great work so far! I've played around with skins a bit, but the lack of docs on it was too much when 2.0 came out with the new skin engine. |
How would that be helpful?
If you could test #1187 and #1243, that would be appreciated. There are tips on the wiki for how to use multiple git worktrees to make it easier to test mappings, skins, and C++ changes together.
With 2 decks, sure, but with 4 decks the overview backgrounds are helpful. |
So do I. That's a reason for being consequent and put all of those indicators behind the toggler. I mostly set them up resp. check them and then hide them.
That's how I handle it myself, too. But it can also be relaxing to clear samplers except those 3-4 samples really used in a session, just to have clean view.
That's a good idea! |
I'm using mixxx without controller and only need keylock on a regular basis / only need to see the status of keylock. So it's nice to show only that. But we have plenty of screenspace nowadays... ;) So +1/2 for keeping it separate. I like it as it is. |
for reference - here's the launchpad bug for the hamburger issue on macOS: |
@foss- Thank you. This way maybe someone else picks up the issue because I don't know who to solve this right now. Last resort would be to make a step back and put settings back inside main skin so that every thing gets squeezed, like in Deere. |
Until this is fixed you could a have a look at skin.xml where all the initial CO values are set and adjust options via mixxx.cfg. |
I'm not sure if I'll get around to this for 2.1. |
I just tested latest master which has this included, and i saw a tiny bug:
Ok... Now I see this has been debated already... |
I styled the Keylock button in #1259: The PR also contains some small fixes in samplers and effect units. I plan to make a row in skin settings where users can select which deck indicators are always visible, because I doubt we come to a clear conclusion on which to show and which not.
|
In #1259 I just added the option to hide all indicators. |
Moving general discussion of the skin back here to keep it in one place...
That makes sense.
I understand wanting to save space this way, but this requires losing the information conveyed by cue_indicator. It is also inconsistent with controllers.
I'd think the number of hotcues to show would be a set-and-forget setting rather than something that would be toggled regularly.
Good job with the samplers! The sync_enabled button in them should be replaced with the old beatsync Control though because master sync doesn't work well with short samples. Refer to this comment. I like the new option to control which deck buttons are always visible.
I was reluctant to do this, but I realized while mixing with effects that matches how I think while mixing. I wonder whether a deck has an effect unit on it, not whether an effect unit is on a deck. This matches the layout of controllers. The only controllers with effect unit assignment buttons that I am aware of that have them in the effect units are the Akai AFX and Denon MC6000 Mk2. On the other hand, all these controllers have them associated with the decks:
|
Done. Tooltip now says: OLD sync control, use sync_enabled...
This was only about simplicity, not saving space.
As I mentioned, to make this consistent Master/Headphone buttons would have to go to Mixerbar. |
I agree that the inconsistency with the headphone and master routing switches for effect units is not ideal. However, making the skin inconsistent with itself in different states by moving the switches depending on whether the mixer bar is showing would be worse. I think they should go in the effect units. |
FX assignment buttons are now in their respective section. Master/Headphone stay in FX unit. If your curious, please test #1259 |
This PR is about testing your opinions whether or not my custom skin could/should be included in future mixxx releases.
Thanks @daschuer who sparked off the idea recently.
Tango is intended to be
Screens (2017-3-10 529c3eb):
minimal view I use most of the time
medium view
netbook (1008x500) full FX, mixer, waveforms & 4 samplers
This is my current ToDo list. Please have a look, add feature requests and share your opinion!
? means option to discuss, ! are urgent issues and everything else are my ToDos.
General / Wording / qss
- simplify/concentrate button styling
- correct font family/size in special nodes
Decks
? Overview bg colors: necessary at all?
....if yes: harmonic color scheme?
? Keylock state: colored when Off or when On? (see this post )
- enlarge time display so elapsed/remaining fits in
Samplers
? does the Repeat button make sense?
? do we need the Eject button? Space is scarse with 8 sampler per row and I'd like to replace it with ..
- quantize button
What do you think?
I'd also like to see screenshots from resolutions other than 1366x768, especially from a 4-decks user with 4 FX units.