Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tango skin #1151

Merged
merged 208 commits into from
May 7, 2017
Merged

Tango skin #1151

merged 208 commits into from
May 7, 2017

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Jan 26, 2017

This PR is about testing your opinions whether or not my custom skin could/should be included in future mixxx releases.

Thanks @daschuer who sparked off the idea recently.

Tango is intended to be

  • minimal: ability turn off all skin elements already present on your controller
  • clear: primarily work with controller but when glancing at the screen important indicators are quick to find and easy to read
  • unobtrusive: I love to hide scrolling waveforms completely since I find them distracting. It puts the focus back on ears and fingers
  • symmetric: don't want to mimic CDJs etc. but keep important buttons/indicators in the centre

Screens (2017-3-10 529c3eb):
minimal view I use most of the time
mixxx_minimal

medium view
mixxx_medium

netbook (1008x500) full FX, mixer, waveforms & 4 samplers
mixxx_netbook

This is my current ToDo list. Please have a look, add feature requests and share your opinion!
? means option to discuss, ! are urgent issues and everything else are my ToDos.

General / Wording / qss
- simplify/concentrate button styling
- correct font family/size in special nodes

Decks
? Overview bg colors: necessary at all?
....if yes: harmonic color scheme?
? Keylock state: colored when Off or when On? (see this post )
- enlarge time display so elapsed/remaining fits in

Samplers
? does the Repeat button make sense?
? do we need the Eject button? Space is scarse with 8 sampler per row and I'd like to replace it with ..
- quantize button

What do you think?
I'd also like to see screenshots from resolutions other than 1366x768, especially from a 4-decks user with 4 FX units.

@ywwg
Copy link
Member

ywwg commented Jan 26, 2017

I see the forum link, but just to keep everything inside github can you attach a screenshot or two with the most recent look to this PR?

@Be-ing
Copy link
Contributor

Be-ing commented Jan 26, 2017

I'll test this later (likely tomorrow), but a few things jump out to me from the screenshots:

  • The aesthetics of this have diverged a lot from LateNight. I think it would be good to come up with a new name.
  • The solid black background in parts of the middle area looks odd. That should probably be a shade of gray.
  • If this is merged for Mixxx 2.1, it should present the new effects UI following new Deere effects units with meta knobs #1063. If you want to keep a 2.0 backwards compatible version of the skin for now to post to the forum, you can make a new git branch from what you have started here.

@daschuer
Copy link
Member

This skin is a candidate for small skins, but the minimum size is bigger than my 1366 x 768 screen.
Window decoration must be considered as well.
Maybe you we can make it fit for 1024 x 786?

@daschuer
Copy link
Member

The gap between the two effect regions is moving and resizing depending on the effect. It would be nice to have it fixed.

@daschuer
Copy link
Member

Wow, it is a lot of fun to play with this skin. Thank you !

@ronso0
Copy link
Member Author

ronso0 commented Jan 28, 2017

Thanks for the feedback so far! Added screenshots and the most recent version as .zip

I think it would be good to come up with a new name

Indeed. 'FlatOne' is my new favourite.

The solid black background in parts of the middle area looks odd

I played around with that already, am not happy yet either. Testing will be much easier if I find a way to make use of #302 i.e. for the spinny masks.
Though I'd like to keep a high contrast for the pitch faders, they're very important to me.

If this is merged for Mixxx 2.1, it should present the new effects UI following #1063

On my list ;) like the JS Effects mapping...

This skin is a candidate for small skins, but the minimum size is bigger than my 1366 x 768 screen.

Until now it was 1010px min-width, now it's 1270). I designed it @ 1366x768, so something is squeezed?

Maybe you we can make it fit for 1024 x 786?

If there's a need, I will. In the forums there was also a request for a portrait mode for tablets. But it I'm afraid it would either a) become much more complex (the code, SizeAwareStacks for Deck buttons, Loop section etc.)
or b) become a whole new skin like FlatOne_800_portait

The gap between the two effect regions is moving and resizing depending on the effect.

Fixed. The spacer in between now also adapts to other situations, and the Effect units only grow if 'graphical EQ' is selected on one side.

Wow, it is a lot of fun to play with this skin. Thank you !

My pleasure! Initially built it for me, and if someone else has fun with it it's win-win-win!
'Playing' means toggling elements on, off, on again? Or DJing? Or both? ;)

@daschuer
Copy link
Member

daschuer commented Jan 28, 2017

'FlatOne' is my new favourite.

I like that name too.

This skin is a candidate for small skins, but the minimum size is bigger than my 1366 x 768 screen.

Until now it was 1010px min-width, now it's 1270). I designed it @ 1366x768, so something is squeezed?

The high is taller than 768. This makes my maximize windows button disappear. The width is much smaller then 1366. You have <MinimumSize>1010,740</MinimumSize> but the sum of the widgets is bigger. Maybe you can just lower the minimum high of the library.

Portrait mode: Does this means to squeeze to 768 width? I would postpone this to an extra skin.

'Playing' means toggling elements on, off, on again? Or DJing? Or both? ;)

This mean just practising DJing at home.

@ronso0
Copy link
Member Author

ronso0 commented Jan 29, 2017

The high is taller than 768. This makes my maximize windows button disappear. The width is much smaller then 1366. You have 1010,740 but the sum of the widgets is bigger. Maybe you can just lower the minimum high of the library.

Shame on me, I didn't consider the menu bar (just window decoration) and didn't test properly.
Now minimum size is 1270x700. Inner window can never be bigger than that, bigger Widgets will just be cropped. But yes, Library can be smaller. I'm repairing that as well.

@ronso0
Copy link
Member Author

ronso0 commented Jan 29, 2017

Updated zip

@Be-ing
Copy link
Contributor

Be-ing commented Jan 30, 2017

I like that you're trying to do things differently, but I think some areas are confusing and need work.

  • When stacked waveforms are on, toggling the library off hides the library, but it can't be toggled back on until stacked waveforms is turned off.
  • The text of the key display is cut off on bottom.
  • It is kinda difficult to see the position of the knobs with white notches like the EQ knobs. There should be more color contrast between the rest of the knob and the notch.
  • Putting the beatgrid manipulation buttons next to the waveforms makes sense, but it's not so great that they are buried in the settings menu.
  • I like the inclusion of the track comment option. I think some users will make heavy use of that.
  • The loop & beatjump button grids could use a bit of padding between the buttons. I'm not sure the button label text needs to be quite that big.
  • The spinny/cover art section of the options panel is confusing. I think the first two options should be condensed to one option with 3 states: show nothing, show cover art, show spinny. I don't know what the third option in that section of the settings does; I don't see a change in the skin when I toggle it.
  • Buttons for skin options that are shown in the center of the skin should only be those that would be toggled while DJing. Everything else can be in the settings menu. I think the whole top row of those buttons can be removed.
  • I don't like that the Mixxx logo and crossfader can't be shown at the same time with 2 decks.
  • The settings menu button should be labeled with text. It's not obvious how to activate it.
  • Somehow I got into a state where the overview waveform swapped places with the deck controls:
    flatnight-bug

@ronso0
Copy link
Member Author

ronso0 commented Jan 30, 2017

Up-to-date screenshots:
almost minimum
flatnite_mini

medium
flatnite_medium

@ronso0
Copy link
Member Author

ronso0 commented Jan 30, 2017

Wow, thanks for your extensive review!

When stacked waveforms are on, toggling the library off hides the library, but it can't be toggled back on until stacked waveforms is turned off.

I'm reworking the lower half. Right now minimum size for Samplers/Library is 83px (Table header and about 3 lines), less than that would be a joke, I think.

The text of the key display is cut off on bottom.

Will fix that!

It is kinda difficult to see the position of the knobs with white notches like the EQ knobs. There should be more color contrast between the rest of the knob and the notch

Seriously? Low contrast was one of the reasons I couldn't work with Deere. Sure they could be plain white but I'd like to hear another opinion on that.

Putting the beatgrid manipulation buttons next to the waveforms makes sense, but it's not so great that they are buried in the settings menu.

Agree. There could be an 'expand' button, exactly like for vinyl options & extra deck buttons.

I like the inclusion of the track comment option. I think some users will make heavy use of that.

It would be cool to have a one-line HotCue label widget like that. Where you could edit HotCue labels on click, without going to Library, then to comments, then editing the comments.

The spinny/cover art section of the options panel is confusing. I think the first two options should be condensed to one option with 3 states: show nothing, show cover art, show spinny

Agreed. Like with Samplers and Decks' HotCues

I don't know what the third option in that [Spinny] section of the settings does; I don't see a change in the skin when I toggle it

Big CoverArt/Spinny where the channel mixer is or small version in the overview waveform. You'll sure see the difference when you hide the mixer -_o

Buttons for skin options that are shown in the center of the skin should only be those that would be toggled while DJing. Everything else can be in the settings menu.

Agree...

I think the whole top row of those buttons can be removed.

...and disagree vehemently! When you normally use a minimal view without scrolling waveforms and other annoying stuff (what I actually made this skin for), these are the most important buttons in the skin!

  • Not sure about the beat grids matching while blending calm tacks? Quickly toggle waveforms!
  • Need access to HotCues while preparing a set without controller? Activate 4 or 8 HotCues!
  • Not sure about EQs when running 4 decks? Show Mixer!
  • Suddenly need a 3rd/4th deck? Activate it!
  • Spinnies? Not sure, I don't use them... Maybe useful for slipmode.

I don't like that the Mixxx logo and crossfader can't be shown at the same time with 2 decks.

Yeah, didn't find a proper solution to that yet, without squeezing the clock/buttons. In one version I put the crossfader on top of the logo, with a fading slider scale. Other suggestions?
And please, keep in mind that this skin is intended as a controller extension. Which controller is lacking a crosfader?

The settings menu button should be labeled with text. It's not obvious how to activate it.

Hm...I was actually trying to make button texts obsolete in general by using explicit icons. I think the hamburger menu icon is somehow an established one since all that smartphone apps, and it's placed quite prominent.

Somehow I got into a state where the overview waveform swapped places with the deck controls

What you mean?

@ronso0
Copy link
Member Author

ronso0 commented Jan 30, 2017

Edited PR description. I'm curious how this skin looks on screens other tha 1366x768. Anyone?

@Be-ing
Copy link
Contributor

Be-ing commented Jan 30, 2017

I'm reworking the lower half. Right now minimum size for Samplers/Library is 83px (Table header and about 3 lines), less than that would be a joke, I think.

I don't think that bug has to do with the minimum height.

Seriously? Low contrast was one of the reasons I couldn't work with Deere. Sure they could be plain white but I'd like to hear another opinion on that.

I think the issue is that the notches blend in with the colors of the rest of the skin, not so much that they're hard to distinguish from the knob. The blue, red, and orange notches stand out much more.

It would be cool to have a one-line HotCue label widget like that. Where you could edit HotCue labels on click, without going to Library, then to comments, then editing the comments.

It sure would, but a lot of work would have to be done on the C++ side for that to happen. There is a Launchpad blueprint for that.

...and disagree vehemently

Okay, we can disagree on that.

Yeah, didn't find a proper solution to that yet, without squeezing the clock/buttons. In one version I put the crossfader on top of the logo, with a fading slider scale. Other suggestions?
And please, keep in mind that this skin is intended as a controller extension. Which controller is lacking a crosfader?

I was thinking that removing the top row of buttons might make room for both, but if you want to keep those I guess there would have to be a different solution.

I realize that your intention is primarily for use with controllers. Personally, I like having the mixer shown on screen when I am using a controller so I don't have to look down at my controller to know where my knobs and sliders are set while focusing on something else on screen, like the waveforms or library.

What you mean?

I see now after looking at your screenshots that is the state it is always in. I find the asymmetry kinda odd. Is there a reason you made the decks asymmetrical like that?

@ronso0
Copy link
Member Author

ronso0 commented Jan 30, 2017

I don't think that bug has to do with the minimum height.

Okay, I did experience something like that when enabling 4 decks + waveforms + FX units, that's why I rework the lower half.
Can't reproduce it. Can you describe how it happened in your case?

I see now after looking at your screenshots that is the state it is always in. I find the asymmetry kinda odd. Is there a reason you made the decks asymmetrical like that?

Coming from LateNight, I initially found it helpful to relate vertically ordered waveforms to horizontally ordered decks, background colors wouldn't help me much. But even now I get confused now and then anyways. If there's a standard like top waveform=left, bottom = right, I will stick to that. In Deere I find it not intuitive that waveforms of decks 3 & 4 would show up below and beneath those of of deck 1 & 2.

... so I don't have to look down at my controller to know where my knobs and sliders are set while focusing on something else on screen, like the waveforms or library.

Okay, we can disagree on that.

I agree that we disagree! :) Who said that? Earth would be so f***ing boring if we all had the same habits and taste.
Deere and LateNight are working quite well for the 'traditional' use cases. I don't want to compete with them, this is a different approach. And I'll find a solution for the crossfader/logo prob, maybe shifted smaller logo above CF

@ronso0
Copy link
Member Author

ronso0 commented Jan 31, 2017

flatnite_mini

flatnite_medium

@ronso0
Copy link
Member Author

ronso0 commented Jan 31, 2017

Next step will be to implement collapsible FX units, both for 2.0 (Effect names + SuperKnob) and 2.1 (Effect names + MetaKnobs).
Having two skin versions is possible, but is there a way to determine the mixxx version and switch certain elements accordingly?

@ronso0
Copy link
Member Author

ronso0 commented Jan 31, 2017

Also on collapsible FX units I need some help:
Currently, vertical space doesn't suffice, i.e when enabling stacked waveforms + 4 decks with beatloop buttons + 4 FX units. Something would be squeezed/cropped. Other than FX units, none of the elements can be compressed adequately to fit while still being useful. And I'd rather not increase MinimumSize of the skin, therefore I'd like to implement the following mode:

  1. FX units collapse automatically when vertical space gets scarce
  2. one row of FX units can be expanded, the other row collapses automatically
  3. when one row is collapsed, the other should not expand automatically

It's possible to get available space for everything below stacked waveforms, but I failed to achieve 3.
I tried several approaches (SizeAwareStacks, WidgetStacks with triggers, nested visibility connections), but to no avail.
Any ideas?

@Be-ing
Copy link
Contributor

Be-ing commented Jan 31, 2017

Also on collapsible FX units I need some help:

I don't think you need to worry about this too much. The new effects UI is designed so the effect units can be in collapsed view most of the time.

It's possible to get available space for everything below stacked waveforms, but I failed to achieve 3.

I don't think the current skin system is smart enough to implement such complex behavior. This is the kind of thing that QML would be really helpful for.

@ronso0
Copy link
Member Author

ronso0 commented Jan 31, 2017

I don't think you need to worry about this too much. The new effects UI is designed so the effect units can be in collapsed view most of the time.

So -on small screens- some elements would need to hidden in order to configure FX units. Okay.

Having two skin versions is possible, but is there a way to determine the mixxx version and switch certain elements accordingly?

Any idea on this?

@Be-ing
Copy link
Contributor

Be-ing commented Jan 31, 2017

So -on small screens- some elements would need to hidden in order to configure FX units. Okay.

Yeah. The expanded view is mostly meant for setting up effect chains, but there shouldn't be a need to keep it expanded while mixing.

Having two skin versions is possible, but is there a way to determine the mixxx version and switch certain elements accordingly?

I don't think so. I suggest making separate git branches.

@ronso0
Copy link
Member Author

ronso0 commented Feb 1, 2017

flatnite_mini

flatnite_medium

Next step is to implement collapsible FX units -both for 2.0 and 2.1- and more logic to avoid odd visual states on small screens. And I'll test how to make it fit 1024px.
So, this will be the last update for a while. Waiting for some more opinions if this has a real chance.
Thanks for the feedback so far!
Cheers!

@Be-ing
Copy link
Contributor

Be-ing commented Feb 1, 2017

Nice work. IMO this is close to ready to merge for the beta. Improvements can continue to be merged during the beta period.

Some more comments:

  • Some buttons (headphones, reloop, effect deck assignment) have a black icon/text color on a gray background in their deactivated state. This is difficult to see. Make them match the other buttons' colors with light gray on a dark gray background.
  • I think the text of the key should be bigger.
  • I like that the record and broadcast buttons are in the middle of the screen, but I feel like the placement of the broadcast icon next to the clock is a little awkward. I'm not sure where else to suggest though.
  • Add some horizontal padding between the "Extra Deck Buttons". Also, I think "Deck Control Buttons" would be a better name.

It's easier to keep track of changes if you split them into smaller commits. If you have a pile of changes you want to commit, you can use git's interactive features to selectively add different changes to different commits, then push them all together. Using a GUI git frontend program can help with that. Personally I like Git-Cola.

@nikmartin
Copy link
Contributor

I added a comment, but you just addressed it, so I'll try your suggested fix.

@ronso0
Copy link
Member Author

ronso0 commented May 8, 2017

Fixed in #1251

@nikmartin
Copy link
Contributor

I thought I had already added this comment, but the + - buttons next to the loop presets don't do anything. Should they extend or shrink the loop size by 1 beat?

@ronso0
Copy link
Member Author

ronso0 commented May 8, 2017

👍 You discovered another 2.1 CO: loop_halve instead of beatloop_halve
Thanks! Added to #1251

@nikmartin
Copy link
Contributor

Regarding usability testing, I've used tango in production for 4 gigs, each lasting about 4 hours and everything worked great. The only usability issues I have are with the state of bit indicators. For example quantize is red when ON, but the other indicators like key lock are red when OFF. The other issue is it's cumbersome to get spinnies with album art and tape markers. The ui for that in the side menu is pretty confusing​, and takes a few clicks to get it like I like it. Those settings never persist even though they should, but that might be a bug.

@ronso0
Copy link
Member Author

ronso0 commented May 9, 2017

Thanks for your feedback!

quantize is red when ON, but the other indicators like key lock are red when OFF

Actually it's just keylock that's not red when it's On. But yeah, there has been some discussion about this, can't find the comments...but it's in the ToDo in 1st post for a reaon -_o
With this indicator colors I didn't follow the On/Off rule, but wanted to grant them attention if their state affects normal playback. Like i.e. with quantize ON, dropping a tune with jogwheels wouldn't work as expected. Or with keylock OFF any tempo change would affect pitch.
I won't stick to this if it contradicts intuition trained by other skins (On=colored, Off=grey), though it feels wrong.

spinnies with album art and tape markers. The ui for that in the side menu is pretty confusing​

What exactly do you find confusing?

Those settings never persist even though they should, but that might be a bug.

It is indeed. Thanks for finding, didn't notice that since changing that option to a 3-state button.
Fixed in #1253

@radusuciu
Copy link
Contributor

Agree with points above that following convention (on=colored, off=grey) is more intuitive.

@nikmartin
Copy link
Contributor

i like the little red magnet with the silver tips, it's a nice touch. That said, red in software almost always means danger. With keylock, grayed/off + some other color/on (green? blue?) etc would work for me. Gray always means OFF, regardless if that is the sane default. In fact, with software that is as user customizable as mixxx, there's really no default. Many DJs would argue that quantize is always bad, so their 'default' is off. Same with keylock. This is really just semantics, and if we changed our term to describe the control as 'Active' or 'Inactive', it almost fixes itself. What's normal for you isn't for me, so the slip mode being active (colored) or inactive(gray) becomes immediately intuitive. If there's another thread on this I'll be glad to reference this comment there as well.

@ronso0
Copy link
Member Author

ronso0 commented May 9, 2017

Okay, intuition wins. Keylock OFF will be grey and I'll try some colours for the ON state.
Any objections to move keylock next to the other indicators so it can be hidden as well, or do you think it's 'special ' and has to stand out?

Feels like a good moment to bring up the ToDo list and continue discussion here. Changes can be applied in a different PR.

Do you think crossfader assignment button in decks is colourful enough?

Correct font family/size in special nodes: are any texts like effect names, BPM or key displays are cropped/shifted on anyone’s OS?

Do you feel that different overview background colours in decks are necessary at all?
If yes: any proposals for a more harmonic colour scheme, at least for monochromatic waveforms?

Does the Repeat button in samplers make sense?
Do we need the Eject button there?
Space is scarse with 8 sampler per row and I'd like to add a quantize button.

@nikmartin
Copy link
Contributor

Yeah this might be a good point to start feature requests against the skin. I'd actually like to see the skins split into separate repos that PRs get done against, then get packaged with mixxx.

Any objections to move keylock next to the other indicators so it can be hidden as well, or do you think it's 'special ' and has to stand out?

This is where it's probably starting to get very user specific, because for example, my controller (DDJ-SB2) has Keylock indicators, so I just look at my controller. Slip mode is good to know, so if I grab a jog wheel to scratch, it'd be good to be able to know and/or switch slip mode on.

Same with crossfaders and mixer components. I turn all those off because I have a physical controller. Regarding samplers, I load name drops and intros into them right at startup (which get saved, yay), and use my sampler buttons on the controller. My preference vs an eject button is to just drag a new track or right click and add to the sampler, thereby replacing the one that may be there now. Never considered the need for repeat on samplers either, but a per sampler channel quantize would be good for drum samples.

Re: overview colors. It's pretty intuitive to me which deck and track overview is which, so the colors don't bring much more information to the UI, so my preference would be to have the same colors but as high contrast as possible because i'm frequently searching the interface looking for the track remaining times.

Symmetrical vs identical overviews I don't have an opinion on, but that might be a future feature to allow switching the deck overviews to a symmetrical layout (title&artist on outside, times near the center, etc).

Great work so far! I've played around with skins a bit, but the lack of docs on it was too much when 2.0 came out with the new skin engine.

@Be-ing
Copy link
Contributor

Be-ing commented May 10, 2017

Yeah this might be a good point to start feature requests against the skin. I'd actually like to see the skins split into separate repos that PRs get done against, then get packaged with mixxx.

How would that be helpful?

for example, my controller (DDJ-SB2) has Keylock indicators

If you could test #1187 and #1243, that would be appreciated. There are tips on the wiki for how to use multiple git worktrees to make it easier to test mappings, skins, and C++ changes together.

Re: overview colors. It's pretty intuitive to me which deck and track overview is which

With 2 decks, sure, but with 4 decks the overview backgrounds are helpful.

@ronso0
Copy link
Member Author

ronso0 commented May 10, 2017

This is where it's probably starting to get very user specific, because for example, my controller (DDJ-SB2) has Keylock indicators, so I just look at my controller.

So do I. That's a reason for being consequent and put all of those indicators behind the toggler. I mostly set them up resp. check them and then hide them.

My preference vs an eject button is to just drag a new track or right click and add to the sampler, thereby replacing the one that may be there now.

That's how I handle it myself, too. But it can also be relaxing to clear samplers except those 3-4 samples really used in a session, just to have clean view.
@Be-ing On another PR you mentioned your idea to create a button for decks or track properties' right-click menu that would host actions like "eject", "show in Library", "clear waveform" etc.
Was it just an idea or do you still plan to do that?

Symmetrical vs identical overviews I don't have an opinion on, but that might be a future feature to allow switching the deck overviews to a symmetrical layout (title&artist on outside, times near the center, etc).

That's a good idea!

@MK-42
Copy link
Contributor

MK-42 commented May 10, 2017

Any objections to move keylock next to the other indicators so it can be hidden as well, or do you think it's 'special ' and has to stand out?

I'm using mixxx without controller and only need keylock on a regular basis / only need to see the status of keylock. So it's nice to show only that. But we have plenty of screenspace nowadays... ;) So +1/2 for keeping it separate. I like it as it is.

@foss-
Copy link
Contributor

foss- commented May 10, 2017

for reference - here's the launchpad bug for the hamburger issue on macOS:
https://bugs.launchpad.net/mixxx/+bug/1689196

@ronso0
Copy link
Member Author

ronso0 commented May 10, 2017

@foss- Thank you. This way maybe someone else picks up the issue because I don't know who to solve this right now. Last resort would be to make a step back and put settings back inside main skin so that every thing gets squeezed, like in Deere.

@ronso0
Copy link
Member Author

ronso0 commented May 10, 2017

Until this is fixed you could a have a look at skin.xml where all the initial CO values are set and adjust options via mixxx.cfg.

@Be-ing
Copy link
Contributor

Be-ing commented May 10, 2017

@Be-ing On another PR you mentioned your idea to create a button for decks or track properties' right-click menu that would host actions like "eject", "show in Library", "clear waveform" etc.
Was it just an idea or do you still plan to do that?

I'm not sure if I'll get around to this for 2.1.

@JosepMaJAZ
Copy link
Contributor

JosepMaJAZ commented May 10, 2017

I just tested latest master which has this included, and i saw a tiny bug:

  • The image for the key lock ( the red note ) is inverted. It is red when disabled, and grey when enabled.

Ok... Now I see this has been debated already...

@ronso0
Copy link
Member Author

ronso0 commented May 11, 2017

I styled the Keylock button in #1259:
Off = grey
On = white on black bg (like Pfl button in channel mixer)
to avoid any emotional co-notation like Danger!, Attention!, Good or Bad

tango_keylock2
tango_keylock

The PR also contains some small fixes in samplers and effect units.

I plan to make a row in skin settings where users can select which deck indicators are always visible, because I doubt we come to a clear conclusion on which to show and which not.
This will be a bit of work but follow the main goal

minimal: ability turn off all skin elements already present on your controller

@ronso0
Copy link
Member Author

ronso0 commented May 12, 2017

In #1259 I just added the option to hide all indicators.
Please test if this makes sense for you.

@ronso0
Copy link
Member Author

ronso0 commented May 13, 2017

In #1259 @Be-ing remarked some confusion about

  • Cue as right-click function of Play button
  • HotCue toggler in top row
  • accessibility of Vinyl Control Options
  • Effect assignment buttons

Any opinions on that?

@Be-ing
Copy link
Contributor

Be-ing commented May 13, 2017

Moving general discussion of the skin back here to keep it in one place...

I watched Traktor Scratch DJs with DVS not caring about CoverArt but using the Spinny.

That makes sense.

Check tooltips of Play button: it's mapped to right click

I understand wanting to save space this way, but this requires losing the information conveyed by cue_indicator. It is also inconsistent with controllers.

About HotCue and Spinny/Cover togglers we had a discussion in #1511, I thought I layed out the respective use cases there.

I'd think the number of hotcues to show would be a set-and-forget setting rather than something that would be toggled regularly.

@Be-ing Your opinion on the actual purpose of this PR?

Good job with the samplers! The sync_enabled button in them should be replaced with the old beatsync Control though because master sync doesn't work well with short samples. Refer to this comment.

I like the new option to control which deck buttons are always visible.

And I somehow still don't like to detach this effect unit specific control from effect units.

I was reluctant to do this, but I realized while mixing with effects that matches how I think while mixing. I wonder whether a deck has an effect unit on it, not whether an effect unit is on a deck. This matches the layout of controllers. The only controllers with effect unit assignment buttons that I am aware of that have them in the effect units are the Akai AFX and Denon MC6000 Mk2. On the other hand, all these controllers have them associated with the decks:

  • Denon MCX8000
  • Numark NV, NVII
  • Numark NS6, NS6II
  • Numark NS7II, NS7III
  • Pioneer DDJ-SX & DDJ-SX2
  • NI Traktor Kontrol S2
  • NI Traktor Kontrol S4 Mk1 & Mk2
  • NI Traktor Kontrol S5
  • NI Traktor Kontrol X1
  • Vestax VCI 400
  • Vestax VCI 100 Mk2

@ronso0
Copy link
Member Author

ronso0 commented May 15, 2017

The sync_enabled button in them should be replaced with the old beatsync Control though because master sync doesn't work well with short samples.

Done. Tooltip now says: OLD sync control, use sync_enabled...

Is there no cue button?
I understand wanting to save space this way, but this requires losing the information conveyed by cue_indicator. It is also inconsistent with controllers.

This was only about simplicity, not saving space.
You're right about the missing Cue information. I added 'Separate Cue button' to skin settings so it can be set visible permanently. Single 2in1 Play button now signals if play position is at Cue point.
I'm not sure how to set the default value because interestingly no one missed in in the last 9 months, maybe due to the readme/introduction in the forums.

And I somehow still don't like to detach this effect unit specific control from effect units.

I was reluctant to do this, but I realized while mixing with effects that matches how I think while mixing. I wonder whether a deck has an effect unit on it, not whether an effect unit is on a deck. This matches the layout of controllers.

As I mentioned, to make this consistent Master/Headphone buttons would have to go to Mixerbar.
May be the reason for my discomfort with removing deck assignment from effect units:
to find out if an effect unit affects any channel, you'd have to check many different places and enable Mixerbar to be sure.
But I see that effect controls should be consistent across skins.
I'll try with only Master & Headphone buttons in effect unit, unless mixerbar is visible.

@Be-ing
Copy link
Contributor

Be-ing commented May 15, 2017

I agree that the inconsistency with the headphone and master routing switches for effect units is not ideal. However, making the skin inconsistent with itself in different states by moving the switches depending on whether the mixer bar is showing would be worse. I think they should go in the effect units.

@ronso0
Copy link
Member Author

ronso0 commented May 17, 2017

FX assignment buttons are now in their respective section. Master/Headphone stay in FX unit.
I also tuned the buttons visual feedback to whether an FX unit is enabled or not.

If your curious, please test #1259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.