Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tango skin: cannot access hamburger menu options on macOS #8859

Closed
mixxxbot opened this issue Aug 23, 2022 · 16 comments
Closed

tango skin: cannot access hamburger menu options on macOS #8859

mixxxbot opened this issue Aug 23, 2022 · 16 comments
Milestone

Comments

@mixxxbot
Copy link
Collaborator

Reported by: foss-4
Date: 2017-05-07T19:46:37Z
Status: Fix Released
Importance: Medium
Launchpad Issue: lp1689196
Tags: skin
Attachments: [mixxx nightly tango skin hamburge menu broken.mp4](https://bugs.launchpad.net/bugs/1689196/+attachment/4873201/+files/mixxx nightly tango skin hamburge menu broken.mp4), skin.xml


macOS 10.12.4
Mixxx nightly 6275

see screencast.

the menu seems to show on the very left, but options are behind existing skin elements and unaccessible (and not readable of course).

@mixxxbot
Copy link
Collaborator Author

Commented by: foss-4
Date: 2017-05-07T19:46:37Z
Attachments: [mixxx nightly tango skin hamburge menu broken.mp4](https://bugs.launchpad.net/mixxx/+bug/1689196/+attachment/4873201/+files/mixxx nightly tango skin hamburge menu broken.mp4)

@mixxxbot
Copy link
Collaborator Author

Commented by: foss-4
Date: 2017-05-09T09:20:56Z


This is the PR introducing Tango skin to master: #1151

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2017-05-10T18:01:22Z


We tried different things to bring skin settings to the front:

  • nesting skin container into another WidgetGroup
  • nesting skin settings template into another WidgetGroup

Apparently all other stacked layouts and WidgetStacks in skin work.
And it seems to happen with OSX only.

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2017-05-13T15:56:54Z


If you don't have any other ideas for how to make the stacking work, I suggest pushing the rest of the skin over like Deere's settings menu.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2017-05-15T17:05:27Z
Attachments: skin.xml


Placing it left to main skin would be last resort.

@foss-4 Could you please try the following skin.xml?

@mixxxbot
Copy link
Collaborator Author

Commented by: foss-4
Date: 2017-05-15T18:04:58Z


Hey ronso0, thanks for digging into this. The skin.xml file from today does not improve the situation.

If you need debugging info find me on irc.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2017-05-17T18:27:18Z


Okay thanks, that would have been to simple.

Since I don't know how to debug qt, here's my last try, maybe related to a focus bug with mac and qt4.8 I found on the net.

To test, please run Mixxx in developer mode (mixxx --developer), then go to Developer menu, pick Developer Tools. In that window's Controls tab type
'settings' in the search box. 'skin_settings' will show up, set its value to 1

If then, skin settings pop up properly (and stay until you click somewhere in main skin) we'd be one step closer.

@mixxxbot
Copy link
Collaborator Author

Commented by: foss-4
Date: 2017-05-18T08:26:11Z


wanted to test this but I assume doing sth wrong with starting from CLI. here's what I tired:

open -a mixxx.app --args developer

Mixxx openes but I don't see a developer menu.

help says:
Usage: open [-e] [-t] [-f] [-W] [-R] [-n] [-g] [-h] [-s <partial SDK name>][-b <bundle identifier>] [-a <application>] [filenames] [--args arguments]
Help: Open opens files from a shell.
      By default, opens each file using the default application for that file.  
      If the file is in the form of a URL, the file will be opened as a URL.
Options: 
      -a                Opens with the specified application.
      -b                Opens with the specified application bundle identifier.
      -e                Opens with TextEdit.
      -t                Opens with default text editor.
      -f                Reads input from standard input and opens with TextEdit.
      -F  --fresh       Launches the app fresh, that is, without restoring windows. Saved persistent state is lost, excluding Untitled documents.
      -R, --reveal      Selects in the Finder instead of opening.
      -W, --wait-apps   Blocks until the used applications are closed (even if they were already running).
          --args        All remaining arguments are passed in argv to the application's main() function instead of opened.
      -n, --new         Open a new instance of the application even if one is already running.
      -j, --hide        Launches the app hidden.
      -g, --background  Does not bring the application to the foreground.
      -h, --header      Searches header file locations for headers matching the given filenames, and opens them.
      -s                For -h, the SDK to use; if supplied, only SDKs whose names contain the argument value are searched.
                        Otherwise the highest versioned SDK in each platform is used.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2017-05-18T12:49:42Z


I don't have any experience with OSX, sorry.
Maybe try this from the directory where mixxx.app is located:
./mixxx --developer

@mixxxbot
Copy link
Collaborator Author

Commented by: foss-4
Date: 2017-05-19T07:55:05Z


no luck so far.

open path/to/mixxx/mixxx.app

works, but

open path/to/mixxx/mixxx.app --developer

just shows the info as pasted above and not open the app.

@mixxxbot
Copy link
Collaborator Author

Commented by: sblaisot
Date: 2017-05-19T09:42:03Z


2 things to try :
open path/to/mixxx/mixxx.app --args "--developer"
open path/to/mixxx/mixxx.app --args -- --developer

@mixxxbot
Copy link
Collaborator Author

Commented by: foss-4
Date: 2017-05-19T09:50:36Z


Sébastien, thanks a bunch.

open path/to/mixxx/mixxx.app --args "--developer"
actually worked.

so opened developer menu > developer tools
"settings" in the search box brings up one result. change value from "0" to "1".

then using the hamburger menu still results in the behavior shown in the initial screencast.

:( sorry I don't have better news.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2017-05-19T14:19:05Z


Okay, thank you for trying.
So I'll move skin settings to the right part of main skin in #1259, where I wanted it to be in the first place and what didn't work out with the 'floating menu'. Also it will be consistent with Deere this way.

Nevertheless it would be good if someone with QT experience looks into this, maybe this bug causes other issues.

@mixxxbot
Copy link
Collaborator Author

Commented by: foss-4
Date: 2017-07-08T09:32:44Z


#1259 has been merged. Setting to "Fix Committed"

@mixxxbot
Copy link
Collaborator Author

Commented by: foss-4
Date: 2017-10-16T10:25:29Z


fix verifed. thanks a lot ronso0.

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.1.0 milestone Aug 24, 2022
@ronso0 ronso0 added skins and removed skin labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants