Added deadline for upgrade to verified #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giocalitri
changed the title
| @@ -252,15 +255,15 @@ def setUpTestData(cls): | |||
| cls.enrollments_json = json.loads(file_obj.read()) | |||
|
|
|||
| cls.enrollments = Enrollments(cls.enrollments_json) | |||
| cls.now = datetime.now(pytz.utc) | |||
|
|
|||
| def test_status_for_run_not_enrolled(self): | |||
| """test for get_status_for_courserun""" | |||
There was a problem hiding this comment.
I just noticed that all of these functions have the same docstring... it's outside the scope of this PR but would you mind updating them?
|
Code looks good, testing functionality |
|
👍 |
giocalitri
force-pushed
the
gdm_honor_upgrade_654
branch
from
4fc5599
to
72e6ec5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
closes #654
What's this PR do?
Introduces a new field in the Course run model to put a deadline to the upgrade to verified
Where should the reviewer start?
courses/models.pyHow should this be manually tested?
Enroll in a course without upgrading. Verify that the
enrolled-not-verifiedin the dashboard REST API appears with aupgrade_deadlineonly in the future or NullAny background context you want to provide?
This will not work in the front-end until #655 is merged