Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed logic for "upgrade" from the front end code #655

Merged
merged 3 commits into from
Jul 5, 2016

Conversation

giocalitri
Copy link
Contributor

What are the relevant tickets?

fixes #648

What's this PR do?

Removes the logic of the upgrade to verified button from the JS code. This logic was based on a field never supplied by the backend. We will implement the correct logic in the backend with #654

Where should the reviewer start?

static/js/util/courseList.js

How should this be manually tested?

if the dashboard rest API returns a enrolled-not-verified code, now the dashboard should show the UPGRADE button

@bdero bdero temporarily deployed to micromasters-ci-pr-655 June 28, 2016 21:00 Inactive
@noisecapella noisecapella self-assigned this Jun 30, 2016
@noisecapella
Copy link
Contributor

Can you go into constants.js and edit DASHBOARD_RESPONSE:

  • Remove verification_date for all runs
  • The course titles have some indication of what the user should see when they look at the courses and runs. Can you adjust the text for the courses for the change in this PR?

@noisecapella
Copy link
Contributor

Other than that everything looks good

@giocalitri
Copy link
Contributor Author

I ended up removing all the enrolled-not-verified cases but 1.

@noisecapella
Copy link
Contributor

Looks good to me 👍

@giocalitri giocalitri merged commit 23dbe58 into master Jul 5, 2016
@giocalitri giocalitri deleted the gdm_frontend_upgrade_648 branch July 5, 2016 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"upgrade to verified" button not appearing when expected
3 participants