Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create AudioContext when it is needed #12460

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

acid-chicken
Copy link
Member

What

必要になるまで AudioContext の生成を遅延する

Why

Related to #12458

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@acid-chicken acid-chicken self-assigned this Nov 26, 2023
@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Nov 26, 2023
Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (755ca97) 78.69% compared to head (5b0a088) 78.72%.

Files Patch % Lines
packages/frontend/src/scripts/sound.ts 25.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12460      +/-   ##
===========================================
+ Coverage    78.69%   78.72%   +0.03%     
===========================================
  Files          948      949       +1     
  Lines       103086   103216     +130     
  Branches      8300     8301       +1     
===========================================
+ Hits         81123    81259     +136     
+ Misses       21963    21957       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit ccb951f into develop Nov 26, 2023
16 checks passed
@syuilo syuilo deleted the create-audio-ctx-when-it-is-needed branch November 26, 2023 05:38
@syuilo
Copy link
Member

syuilo commented Nov 26, 2023

👍

camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants