Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance(frontend): 通知音にドライブのファイルを使用できるように #12447

Merged
merged 23 commits into from
Nov 27, 2023
Merged

enhance(frontend): 通知音にドライブのファイルを使用できるように #12447

merged 23 commits into from
Nov 27, 2023

Conversation

kakkokari-gtyih
Copy link
Contributor

What

  • 通知音にドライブのファイルを使用できるようにした
  • 通知音周りの型定義を整理した

image

長い音声の場合は警告が表示される

image

音声ではない場合は選択できない

image

Why

Fix #9403

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Nov 25, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 25, 2023 •
edited
Loading

Codecov Report

Attention: 66 lines in your changes are missing coverage. Please review.

Comparison is base (01d06e7) 78.68% compared to head (46a70c4) 78.69%.

Files Patch % Lines
packages/frontend/src/scripts/sound.ts 40.54% 66 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##           develop   #12447    +/-   ##
=========================================
  Coverage    78.68%   78.69%            
=========================================
  Files          949      951     +2     
  Lines       103120   103409   +289     
  Branches      8301     8302     +1     
=========================================
+ Hits         81141    81378   +237     
- Misses       21979    22031    +52

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih
Copy link
Contributor Author

ちょっとファイル名の表示で不具合があるので

@kakkokari-gtyih
Copy link
Contributor Author

完了

@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented Nov 26, 2023 •
edited
Loading

このPRでは音声周りの型定義などを大幅に変更したので先に他のサウンド関連の変更をマージしたほうが良さそう

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

たぶんいけた

@syuilo syuilo merged commit 2a451eb into misskey-dev:develop Nov 27, 2023
15 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 27, 2023

👍

@kakkokari-gtyih kakkokari-gtyih deleted the enh-9403 branch December 8, 2023 06:35
camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
@kakkokari-gtyih @camilla-ett
enhance(frontend): 通知音にドライブのファイルを使用できるように (misskey-dev#12447)
c9739ee 
* (enhance) サウンドにドライブのファイルを使用できるように

* Update Changelog

* fix

* fix design

* fix design

* Update store.ts

* (fix) ファイル名表示

* refactor

* (refactor) better types

* operationTypeとsoundTypeの混同を防止

* (refactor)

* (fix)

* enhance jsdoc

* driveFile -> _driveFile_
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syuilo syuilo syuilo left review comments

Assignees
No one assigned
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ユーザーがアップロードした音源を通知音に使用できる機能
2 participants
@kakkokari-gtyih @syuilo