Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix pullreq number may not get correctly #12127

Merged

Conversation

anatawa12
Copy link
Member

@anatawa12 anatawa12 commented Oct 24, 2023

What

Fix #12122 (comment)
Fix action failure #6620608207

Why

github.event.workflow_run.pull_requestsが空になってることがあるため

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@anatawa12 anatawa12 changed the title Ci fix pullreq number may not got ci: fix pullreq number may not get correctly Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b22066b) 79.21% compared to head (fe46714) 79.20%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12127      +/-   ##
===========================================
- Coverage    79.21%   79.20%   -0.01%     
===========================================
  Files          939      939              
  Lines       100561   100561              
  Branches      8181     8175       -6     
===========================================
- Hits         79658    79648      -10     
- Misses       20903    20913      +10     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo syuilo merged commit 7e15f71 into misskey-dev:develop Oct 24, 2023
18 checks passed
@syuilo
Copy link
Member

syuilo commented Oct 24, 2023

🙏🏻

kanarikanaru pushed a commit to kanarikanaru/misskey that referenced this pull request Nov 2, 2023
* Revert "remove save-pr-number"

This reverts commit 085f4bd.

* Revert "Update report-api-diff.yml"

This reverts commit b73daf4.

* Revert "Update report-api-diff.yml"

This reverts commit cbf2b5a.

* Revert "try to get pull request id from github.event.workflow_run.pull_requests"

This reverts commit 07517ce.
@anatawa12 anatawa12 deleted the ci-fix-pullreq-number-may-not-got branch November 24, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pull_req時にAPI diffの実行ができない
3 participants