Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull_req時にAPI diffの実行ができない #12122

Closed
tai-cha opened this issue Oct 23, 2023 · 7 comments · Fixed by #12123 or #12127
Closed

pull_req時にAPI diffの実行ができない #12122

tai-cha opened this issue Oct 23, 2023 · 7 comments · Fixed by #12123 or #12127
Labels
🐛Bug Unexpected behavior 🛠️Dev Development of Misskey itself

Comments

@tai-cha
Copy link
Contributor

tai-cha commented Oct 23, 2023

💡 Summary

pull_req時にAPI diffの実行ができない

🥰 Expected Behavior

API diffの実行をしてコメントが投稿される

🤬 Actual Behavior

権限が足りなく実行できない

📝 Steps to Reproduce

  1. MisskeyにPRを送る
  2. CIが走る
  3. 失敗する
@tai-cha tai-cha added 🛠️Dev Development of Misskey itself ⚠️bug? This might be a bug labels Oct 23, 2023
@tai-cha tai-cha self-assigned this Oct 23, 2023
@tai-cha
Copy link
Contributor Author

tai-cha commented Oct 23, 2023

@tai-cha
Copy link
Contributor Author

tai-cha commented Oct 23, 2023

Misskey以外からPRを送った際に実行できない問題、自分のPRでは動いていたので完全に見落としていた

@tai-cha
Copy link
Contributor Author

tai-cha commented Oct 23, 2023

数日中、遅くとも今週中にはやる

@anatawa12
Copy link
Member

着手してもいいです?

@tai-cha
Copy link
Contributor Author

tai-cha commented Oct 23, 2023

@anatawa12 可能であればお願いします!自分のassign外しておきます:pray:

@anatawa12
Copy link
Member

https://github.com/misskey-dev/misskey/actions/runs/6620608207

やっぱりpullreqの取得失敗してる(github.event.workflow_run.pull_requestsが空になってる)のでartifacts経由でpullreq番号渡すのに戻したほうが良さそうなので戻すpullreqなげます。

Run # find first pull requests that targets this repository
  # find first pull requests that targets this repository
  PR_NUMBER="$(echo "$PULL_REQUESTS" \
      | jq --arg REPO_ID "$REPO_ID" '[.[] | select ($REPO_ID == (.base.repo.id | tostring)) | .number ][0]')"
  echo "pr-number=$PR_NUMBER" >> "$GITHUB_OUTPUT"
  shell: /usr/bin/bash -e {0}
  env:
    PULL_REQUESTS: []
    REPO_ID: 77326607

@anatawa12
Copy link
Member

#12124 (comment)
🎉 動いてそうですね

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛Bug Unexpected behavior 🛠️Dev Development of Misskey itself
Projects
None yet
2 participants