ci: fix pull_req時にAPI diffの実行ができない #12123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anatawa12
commented
Oct 23, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12123 +/- ##
===========================================
- Coverage 79.23% 79.18% -0.06%
===========================================
Files 939 939
Lines 100419 100561 +142
Branches 8161 8170 +9
===========================================
+ Hits 79569 79631 +62
- Misses 20850 20930 +80 ☔ View full report in Codecov by Sentry. |
|
OKだと思います |
|
元のスクリプトだとapi-base.json, api-head.jsonも同じArtifactに含まれていたのですが、Diffだけでなくこちらも改めて同梱するようにしていただけたら助かります:pray: 実際にユースケースとしてdiffの比較だけでなくapi-head.jsonもリファレンスとしてDL可能にすることを想定しているため |
|
Report API Diffのartifactsにもapi-{base,head}.jsonを含めるようにしました |
|
変更点とは関係ないとこで落ちてますね... |
|
|
|
🙏🙏🙏 |
kanarikanaru
pushed a commit
to kanarikanaru/misskey
that referenced
this pull request
Nov 2, 2023
* initial commit for report-api-diff.yml
* add api-{base,head}.json into api-artifact
* try to get pull request id from github.event.workflow_run.pull_requests
* Update report-api-diff.yml
* Update report-api-diff.yml
* remove save-pr-number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix #12122
Why
Additional info (optional)
default branchにworkflowがないと一切動作しないので、 https://github.com/anatawa12/misskey で
api-diff(このprのhead)をdefault branchにしてるので、ここに適当なpullreq投げていただけると動作確認できると思います。anatawa12#1
Checklist