feat: Server rules #10660
Merged
feat: Server rules #10660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
packages/backend
Codecov Report
@@ Coverage Diff @@
## develop #10660 +/- ##
===========================================
+ Coverage 75.50% 76.07% +0.57%
===========================================
Files 735 898 +163
Lines 68576 88689 +20113
Branches 5946 6259 +313
===========================================
+ Hits 51780 67474 +15694
- Misses 16796 21215 +4419
... and 161 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
EbiseLutica
previously approved these changes
Apr 17, 2023
acid-chicken
requested changes
Apr 17, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
e2eテスト自体は動くようになったけどサインアップ前にルール確認のステップが入るようになった影響で結局テストは落ちるわね |
|
あれやっぱりe2eが走らない |
|
|
e2eテストが走らない問題をどうにかしないとどうにもならん |
|
やっと走ったけどまだ落ちてる |
|
|
|
こういう場合どうしたらいいんだ |
|
MkFolderも同様の問題がありそう |
|
これでどうだ |
|
おー通った |
|
🙏🙏🙏 |
sasagar
pushed a commit
to sasagar/misskey
that referenced
this pull request
May 9, 2023
* enhance(frontend): サーバールールのデザイン調整 * enhance(frontend): i18n * enhance(frontend): 利用規約URLの設定を「モデレーション」ページへ移動 * enhance(frontend): サーバールールのデザイン調整 * Update CHANGELOG.md * 不要な差分を削除 * fix(frontend): lint * ui tweak * test: add stories * tweak * test: bind args * test: add interaction tests * fix bug * Update packages/frontend/src/pages/admin/server-rules.vue Co-authored-by: Ebise Lutica <[email protected]> * Update misskey-js.api.md * chore: windowを明示 * 🎨 * refactor * 🎨 * 🎨 * fix e2e test * 🎨 * 🎨 * fix icon * fix e2e --------- Co-authored-by: Ebise Lutica <[email protected]> Co-authored-by: Acid Chicken (硫酸鶏) <[email protected]>
na2na-p
pushed a commit
to na2na-p/misskey
that referenced
this pull request
May 10, 2023
* enhance(frontend): サーバールールのデザイン調整 * enhance(frontend): i18n * enhance(frontend): 利用規約URLの設定を「モデレーション」ページへ移動 * enhance(frontend): サーバールールのデザイン調整 * Update CHANGELOG.md * 不要な差分を削除 * fix(frontend): lint * ui tweak * test: add stories * tweak * test: bind args * test: add interaction tests * fix bug * Update packages/frontend/src/pages/admin/server-rules.vue Co-authored-by: Ebise Lutica <[email protected]> * Update misskey-js.api.md * chore: windowを明示 * 🎨 * refactor * 🎨 * 🎨 * fix e2e test * 🎨 * 🎨 * fix icon * fix e2e --------- Co-authored-by: Ebise Lutica <[email protected]> Co-authored-by: Acid Chicken (硫酸鶏) <[email protected]>
|
なんでMkModalのスクロールをなくしたのかなと思ったけど結局MkModalの内側でスクロールすべきという話になったのかしら |
|
復活させたらそれはそれで動かないものが出てくる？ |
|
memo |
だった気がするけどよく覚えてない
復活させても特に問題なかったから復活させる |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #10633
Resolve #10595