Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: サーバールール #10633

Closed
wants to merge 8 commits into from

Conversation

EbiseLutica
Copy link
Contributor

@EbiseLutica EbiseLutica commented Apr 14, 2023

Resolve #10595

What

新規登録前に表示するサーバールールを設定できる機能を追加しました。

設定UIはコントロールパネル » モデレーション にあります。

image

サーバールールが1つでも設定されていると、新規登録画面がこのようになります。

image

サーバールールがある場合、新規登録フォームから同意を求めるスイッチを非表示にしています。

image

Why

#10595 を参照

Additional info (optional)

  • より適切だと思ったので、利用規約URLの設定を 一般 » モデレーション に移動しました

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR labels Apr 14, 2023
@EbiseLutica EbiseLutica changed the title Feature/server rules サーバールール Apr 14, 2023
@github-actions github-actions bot requested a review from tamaina April 14, 2023 06:31
@tamaina
Copy link
Contributor

tamaina commented Apr 14, 2023

Mastodon的なやつか

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #10633 (b3705fd) into develop (d2d1784) will decrease coverage by 19.21%.
The diff coverage is 71.42%.

@@             Coverage Diff              @@
##           develop   #10633       +/-   ##
============================================
- Coverage    94.71%   75.51%   -19.21%     
============================================
  Files            2      734      +732     
  Lines          454    68531    +68077     
  Branches        59     5948     +5889     
============================================
+ Hits           430    51749    +51319     
- Misses          24    16782    +16758     
Impacted Files Coverage Δ
packages/backend/src/server/api/endpoints/meta.ts 75.21% <0.00%> (ø)
...kend/src/server/api/endpoints/admin/update-meta.ts 64.91% <60.00%> (ø)
packages/backend/src/models/entities/Meta.ts 100.00% <100.00%> (ø)

... and 729 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tamaina tamaina changed the title サーバールール feat: サーバールール Apr 14, 2023
@EbiseLutica EbiseLutica requested a review from syuilo April 14, 2023 06:48
@EbiseLutica
Copy link
Contributor Author

スクショ添付忘れてたので追記しました

@syuilo
Copy link
Member

syuilo commented Apr 17, 2023

ちょっとUI調整する

@syuilo syuilo self-assigned this Apr 17, 2023
@syuilo
Copy link
Member

syuilo commented Apr 17, 2023

こんな感じにしてみた
image

@EbiseLutica
Copy link
Contributor Author

@syuilo 全体的に良さそう
「基本的な注意事項」の項目は https://misskey-hub.net/docs/notes.html の文言移す感じかしら

@syuilo
Copy link
Member

syuilo commented Apr 17, 2023

@syuilo 全体的に良さそう 「基本的な注意事項」の項目は https://misskey-hub.net/docs/notes.html の文言移す感じかしら

今のところリンクだけどいちいち外部サイトに飛ぶのもUX悪いし将来的に改善しても良さそう

@EbiseLutica
Copy link
Contributor Author

#10472 もあるしゆくゆくはそのほうが良いね

@syuilo
Copy link
Member

syuilo commented Apr 17, 2023

ほむ
image

@EbiseLutica
Copy link
Contributor Author

これどっか押して許可しないといけないんだっけ…?

@EbiseLutica
Copy link
Contributor Author

所有者がorganizationsだからAllow edits from maintainersが使えないっぽい 😭
https://qiita.com/ryysud/items/4d31dd86efab34a7fbaf

@syuilo syuilo mentioned this pull request Apr 17, 2023
@syuilo
Copy link
Member

syuilo commented Apr 17, 2023

新しくPR作った
#10660

@syuilo
Copy link
Member

syuilo commented Apr 17, 2023

のでこちらは閉じます 🙏🏻

@syuilo syuilo closed this Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

新規登録前にサーバールールの要約を表示できる機能
3 participants