Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goodbye Travis and AppVeyor, welcome Actions! #19

Merged
merged 6 commits into from
Jan 26, 2021

Conversation

riccardoporreca
Copy link
Member

@riccardoporreca riccardoporreca commented Jan 26, 2021

Closes #14.

The CI workflow setup can be reviewed, although this PR should be merged after including the fix to macOS-latest (oldrel) in #15 via PR #17.

* Workflow based on `usethis::use_github_action("check-standard", save_as = "ci.yaml")`.
* Triggered on any branch, full matrix of OS's and R versions.
* Badge based on `usethis::use_github_actions_badge()`, link made specific to the R-CMD-check workflow.
* Same setup as for the former Travis CI.
* This works around the fact that, in certain circumstances, we cannot rely on errors propagating with proper `std::invalid_argument` class / error message. See also RcppCore/Rcpp#972
Copy link
Member

@RolandASc RolandASc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would vote for removing AppVeyor as well. But the PR is fine either way.

* Made redundant by the GH actions workflow (#14), covering Windows checks on several R versions.
@riccardoporreca
Copy link
Member Author

I think I would vote for removing AppVeyor as well. But the PR is fine either way.

Done with 3e304ae

@riccardoporreca
Copy link
Member Author

riccardoporreca commented Jan 26, 2021

Note that the failure reported by the battery of checks is due to a tiny detected reduction in code coverage, which is not an issue and might be an artifact, as a second codecov check shows no changes.

@riccardoporreca riccardoporreca changed the title Goodbye Travis, welcome Actions! Goodbye Travis and AppVeyor, welcome Actions! Jan 26, 2021
@riccardoporreca riccardoporreca merged commit 73d0ca8 into master Jan 26, 2021
@riccardoporreca riccardoporreca deleted the feature/14-ci-gh-actions branch January 26, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move CI to GitHub Actions
2 participants