Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS test failures #15

Closed
riccardoporreca opened this issue Jan 25, 2021 · 2 comments
Closed

Fix macOS test failures #15

riccardoporreca opened this issue Jan 25, 2021 · 2 comments
Labels

Comments

@riccardoporreca
Copy link
Member

riccardoporreca commented Jan 25, 2021

Revealed by the new GH Actions workflow for macOS-latest (oldrel) (3.6.3) => https://github.com/miraisolutions/rTRNG/runs/1765618265?check_suite_focus=true

[ FAIL 30 | WARN 0 | SKIP 0 | PASS 581 ]

All errors are of the form

 ── Failure (test-TRNG.Random.R:135:3): TRNGsplit errors for out-of-range subsequence indices ──
`TRNGsplit(p, p + 1L)` threw an error with unexpected class.
Expected class: std::invalid_argument
Actual class:   simpleError/error/condition
Message:        c++ exception (unknown reason)

and correspond to the current r-oldrel-macos-x86_64 for the released package version 4.20-1 on CRAN (in CRAN checks).

This reveals the approach in #10 (e4ac407) is not working on this platform and should be addressed differently.

@riccardoporreca
Copy link
Member Author

This is most likely related to what described in RcppCore/Rcpp#972.

We need to work around the fact that, in certain circumstances (architectures / compilers), we cannot rely on errors propagating with proper std::invalid_argument class / error message.

@riccardoporreca
Copy link
Member Author

Fixed in b292e3a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant