Fix #223 by skipping the setting of object_id if it is empty #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
Thanks for your help in resolving this. Do you have an estimate of when you might make a new release? I'm looking to use capnp-rpc in production, so it would be convenient if I could use a released package. |
|
Probably in a few weeks. It hasn't been tested much with the C++ version, so you might find other things! What I normally do with projects using the latest version |
|
Great thanks |
talex5
added a commit
to talex5/opam-repository
that referenced
this pull request
Apr 6, 2021
…nix and capnp-rpc-lwt (1.0) CHANGES: - Skip the setting of `object_id` if it is empty (@LasseBlaauwbroek mirage/capnp-rpc#224). This improves interoperability with the C++ implementation. - Use `open_in_bin` instead of `open_in` for Windows compatibility (@MisterDA mirage/capnp-rpc#222).
talex5
added a commit
to talex5/opam-repository
that referenced
this pull request
Apr 6, 2021
…nix and capnp-rpc-lwt (1.0) CHANGES: - Skip the setting of `object_id` if it is empty (@LasseBlaauwbroek mirage/capnp-rpc#224). This improves interoperability with the C++ implementation. - Use `open_in_bin` instead of `open_in` for Windows compatibility (@MisterDA mirage/capnp-rpc#222).
talex5
added a commit
to talex5/opam-repository
that referenced
this pull request
Apr 6, 2021
…nix and capnp-rpc-lwt (1.0) CHANGES: - Skip the setting of `object_id` if it is empty (@LasseBlaauwbroek mirage/capnp-rpc#224). This improves interoperability with the C++ implementation. - Use `open_in_bin` instead of `open_in` for Windows compatibility (@MisterDA mirage/capnp-rpc#222).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.