Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #223 by skipping the setting of object_id if it is empty #224

Merged
merged 1 commit into from
Feb 18, 2021
Merged

Fix #223 by skipping the setting of object_id if it is empty #224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion capnp-rpc-net/serialise.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ module Make (EP : Capnp_core.ENDPOINT) = struct
let b = Message.init_root ~message_size:100 () in
let boot = Message.bootstrap_init b in
Bootstrap.question_id_set boot (QuestionId.uint32 qid);
Schema.BuilderOps.write_string (Bootstrap.deprecated_object_id_get boot) object_id;
if not (String.equal object_id "") then
Schema.BuilderOps.write_string (Bootstrap.deprecated_object_id_get boot) object_id;
Message.to_message b
| `Call (qid, target, request, descs, results_to) ->
let c = Msg.Request.writable request in
Expand Down