-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating file paths and other issues with windows environment #567
Updating file paths and other issues with windows environment #567
Conversation
Codecov Report
@@ Coverage Diff @@
## master #567 +/- ##
=======================================
Coverage 96.81% 96.81%
=======================================
Files 54 54
Lines 6619 6620 +1
=======================================
+ Hits 6408 6409 +1
Misses 211 211 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harshpalan I know you're finishing this up, but fantastic job so far!
See my comments and let me know if anything's not clear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic job @harshpalan 🎉
Feel free to merge this!
Creating a PR to update issues with test cases and other files while building for the Windows environment.