Skip to content

Commit

Permalink
Adding loader for (Compmusic) Carnatic Music Rhythm (#560)
Browse files Browse the repository at this point in the history
* script and indexes

* [WIP] loader and preparing tests

* fixing index

* fix indexs again

* writing tests, fixing bugs

* trim testing audio

* docstrings, docs, remotes...

* add test example to test_loaders and optional dep

* mock dep and add try/except in module

* remove use of pandas

* edit tox

* formetting

* minor fix and update tox

* change error in metadat and use smart_open

* raising error before using openpyxl

* go back to try except

* trying workaround for openpyxl specific error

* load_workbook-->get_xlxs

* fix docs and metadata for full dataset

* fix loading metadata, add more tests

* trying with specific version in pandas docs

* address warnings in docstring

* minor fix in loader for subset

* minor fix in load metadata

Co-authored-by: Marius Miron <[email protected]>
  • Loading branch information
genisplaja and nkundiushuti authored Nov 22, 2022
1 parent c8865cb commit 4b67c85
Show file tree
Hide file tree
Showing 19 changed files with 4,752 additions and 5 deletions.
8 changes: 8 additions & 0 deletions docs/source/mirdata.rst
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,14 @@ cante100
:inherited-members:


compmusic_carnatic_rhythm
^^^^^^^^^^^^^^^^^^^^^^^^^

.. automodule:: mirdata.datasets.compmusic_carnatic_rhythm
:members:
:inherited-members:


compmusic_hindustani_rhythm
^^^^^^^^^^^^^^^^^^^^^^^^^^^

Expand Down
4 changes: 0 additions & 4 deletions docs/source/quick_reference.rst
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ Key
^^^
Musical key. This can be defined globally for an audio file or as a sequence of events.


.. _lyrics:

Lyrics
Expand All @@ -109,16 +108,13 @@ Lyrics corresponding to the singing voice of the audio. These may be raw text wi
or they may be time-aligned events. They may have varying levels of granularity (paragraph, line, word,
phoneme, character) depending on the dataset.


.. _meter:

Meter
^^^^^^
Rhythmic meter for each measure. A classical example of meter in Western music would be 4/4. Details how
many subdivisions and the length of this subdivisions that we do have per each measure.



.. _melody:

Melody
Expand Down
14 changes: 13 additions & 1 deletion docs/source/table.rst
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,19 @@
- 100
- :cante:`\ `

* - .. line-block::

(CompMusic)
Carnatic Rhythm

- - audio: 🔑
- annotations: 🔑
- - :ref:`beats`
- :ref:`meter`
- 176
- .. image:: https://licensebuttons.net/l/by-nc-sa/4.0/80x15.png
:target: https://creativecommons.org/licenses/by-nc-sa/4.0

* - .. line-block::

(CompMusic)
Expand All @@ -67,7 +80,6 @@
:target: https://creativecommons.org/licenses/by-nc-sa/4.0

* - .. line-block::
(CompMusic)
Indian Tonic

Expand Down
Loading

0 comments on commit 4b67c85

Please sign in to comment.