-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rabbitmq health checks for Bytes integration tests instead of sleep() #920
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not entirely sure if this is exactly the bottleneck (since we don't have the facts), but it does look very plausible and it's good to have these health checks anyway.
The only thing is we should probably have fewer retries than you suggested since that service shouldn't take that long to load
…l-kat-coordination into fix/bytes-flaky-rabbitmq-issues
@ammar92 check! |
I remember seeing an amqp error in the tests, so this might be the cause... |
* main: (39 commits) Add delete oois permission (#783) Implement openmetrics endpoint in mula (#662) Rabbitmq health checks for Bytes integration tests instead of sleep() (#920) Groups and Permissions for Organization member (#606) Wrap all import errors in ModuleExceptions while resolving plugins (#818) Feature/octopoes path queries (#851) Fix reset scan profile bug and reduce octopoes calls in view (#910) Fix fierce normalizer to create hostnames without a trailing dot (#909) Updated playwright (#903) Use superuser credentials from .env file (#860) Localize account scoped url's (#861) Dependabot merges (#902) Updated linter configs (#834) Fix cancel url at organization edit view (#850) Add OpenTelemetry tracing to Mula, Bytes, Keiko, and KATalogus (#831) Normalizers should be defined as generators (#830) Rdo workflows (#816) Updated linter configs (#825) Add `rocky_version` to footer (#821) Update PR template with PGP-sign checkbox and absolute URL's (#826) ...
Changes
Attempts to tackle the flaky issues from the Bytes CI. Also see this action for the logs: https://github.com/minvws/nl-kat-coordination/actions/runs/4883917359/jobs/8716061057?pr=761
Code Checklist
Communication
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.