Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated linter configs #834

Merged
merged 23 commits into from
May 2, 2023
Merged

Updated linter configs #834

merged 23 commits into from
May 2, 2023

Conversation

ammar92
Copy link
Contributor

@ammar92 ammar92 commented May 1, 2023

Changes

Enabled and fixed these ruff plugins:

  • SIM

kat_webpage_analysis now has a USERAGENT environment setting

More to enable and fix soon.

Issue link

#784

Code Checklist

  • This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
  • I have written unit tests for the changes or fixes I made.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have made corresponding changes to the documentation, if necessary.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder.

Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder.

@ammar92
Implemented and fixed G option
feb8b8a
@ammar92
Added RET to todo list
6e3b289
@ammar92
Merge branch 'main' into fix/linter-configs
eb98855 
# Conflicts:
#	bytes/bytes/api/router.py
@ammar92
Updated and implemented INP
2cf52f3
@ammar92
Implemented and fixed T20
8d03c08
@ammar92
Revered internetnl_spf_parser.py
0701f84 
Signed-off-by: ammar <[email protected]>
@ammar92
Merge branch 'main' into fix/linter-configs
e656cbd 
# Conflicts:
#	rocky/tests/katalogus/test_katalogus_plugin_detail.py
@ammar92
Merge branch 'main' into fix/linter-configs
b14850f
@ammar92
Implemented ISC
23b5beb
@ammar92
Implemented PTH
28e146d
@ammar92
Updated config file
7aa28fa
@ammar92
Merge branch 'main' into fix/linter-configs
3ddfa84 
# Conflicts:
#	boefjes/tests/test_app.py
#	keiko/keiko/logging.py
#	mula/scheduler/context/context.py
#	octopoes/octopoes/api/api.py
#	octopoes/octopoes/tasks/tasks.py
#	pyproject.toml
@ammar92
Fixed simple errors
293d58f
@ammar92
Fixed kat_webpage_analysis environment settings
eb2a6b4 
Signed-off-by: ammar <[email protected]>
@ammar92
Implemented SIM fixes
4ae242a 
Signed-off-by: ammar <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023 •
edited
Loading

File Coverage
All files 65% ❌
bits/definitions.py 64% ❌
bits/runner.py 56% ❌
bits/https_availability/https_availability.py 93% ✅
bits/oois_in_headers/oois_in_headers.py 57% ❌
bits/spf_discovery/internetnl_spf_parser.py 55% ❌
bits/spf_discovery/spf_discovery.py 72% ❌
octopoes/api/api.py 60% ❌
octopoes/api/models.py 75% ✅
octopoes/api/router.py 52% ❌
octopoes/core/app.py 69% ❌
octopoes/core/service.py 46% ❌
octopoes/events/events.py 96% ✅
octopoes/events/manager.py 65% ❌
octopoes/models/__init__.py 86% ✅
octopoes/models/datetime.py 66% ❌
octopoes/models/exception.py 83% ✅
octopoes/models/origin.py 70% ❌
octopoes/models/path.py 99% ✅
octopoes/models/types.py 95% ✅
octopoes/models/ooi/certificate.py 96% ✅
octopoes/models/ooi/email_security.py 95% ✅
octopoes/models/ooi/findings.py 94% ✅
octopoes/models/ooi/network.py 97% ✅
octopoes/models/ooi/service.py 91% ✅
octopoes/models/ooi/software.py 71% ❌
octopoes/models/ooi/web.py 81% ✅
octopoes/models/ooi/dns/records.py 95% ✅
octopoes/models/ooi/dns/zone.py 77% ✅
octopoes/repositories/ooi_repository.py 40% ❌
octopoes/repositories/origin_parameter_repository.py 53% ❌
octopoes/repositories/origin_repository.py 53% ❌
octopoes/repositories/scan_profile_repository.py 45% ❌
octopoes/xtdb/client.py 39% ❌
octopoes/xtdb/query_builder.py 69% ❌
octopoes/xtdb/related_field_generator.py 72% ❌
tests/conftest.py 91% ✅

Minimum allowed coverage is 75%

Generated by 🐒 cobertura-action against 1fd5bad

@ammar92 ammar92 marked this pull request as ready for review May 1, 2023 08:03
@ammar92 ammar92 requested a review from a team as a code owner May 1, 2023 08:03
@ammar92
Rework
0313af7 
Signed-off-by: ammar <[email protected]>
@ammar92
Rework
af0dcdd 
Signed-off-by: ammar <[email protected]>
@ammar92
Rework
f40ca7d 
Signed-off-by: ammar <[email protected]>
@ammar92 ammar92 requested a review from dekkers May 1, 2023 13:08
@dekkers dekkers merged commit 4fcd0ce into main May 2, 2023
@dekkers dekkers deleted the fix/linter-configs branch May 2, 2023 09:20
jpbruinsslot added a commit that referenced this pull request May 8, 2023
@jpbruinsslot
Merge branch 'main' into feature/optimize-scheduler
89da02b 
* main: (39 commits)
  Add delete oois permission (#783)
  Implement openmetrics endpoint in mula (#662)
  Rabbitmq health checks for Bytes integration tests instead of sleep() (#920)
  Groups and Permissions for Organization member (#606)
  Wrap all import errors in ModuleExceptions while resolving plugins (#818)
  Feature/octopoes path queries (#851)
  Fix reset scan profile bug and reduce octopoes calls in view (#910)
  Fix fierce normalizer to create hostnames without a trailing dot (#909)
  Updated playwright (#903)
  Use superuser credentials from .env file (#860)
  Localize account scoped url's (#861)
  Dependabot merges (#902)
  Updated linter configs (#834)
  Fix cancel url at organization edit view (#850)
  Add OpenTelemetry tracing to Mula, Bytes, Keiko, and KATalogus (#831)
  Normalizers should be defined as generators (#830)
  Rdo workflows (#816)
  Updated linter configs (#825)
  Add `rocky_version` to footer (#821)
  Update PR template with PGP-sign checkbox and absolute URL's (#826)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@underdarknl underdarknl underdarknl left review comments

@dekkers dekkers dekkers approved these changes

Assignees
No one assigned
Labels
python tech-debt
Projects
KAT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ammar92 @dekkers @underdarknl