Do not propagate scan level from DNSSPFMechanismHostname #721
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not propagating the scan level from DNSSPFMechanismHostname to Hostname will prevent a lot of not directly related objects from being added. It it also similar to what we already do in other places such as MX records where we also don't propagate the scanlevel to the target name of the MX record.
Fixes #673
Changes
Please describe the essence of this PR in a few sentences.
Issue ticket number and link
Please paste a link to the issue on the project board here. Alternatively, if there was no submitted issue prior to this PR, you may add this PR to the project board directly.
Proof
Please paste some screenshots or other proof of your (working) change here. If you feel that this is not required (e.g. this PR is trivial), note that here.
Extra instructions for others
This section may be skipped or omitted. Uncomment and answer the below questions if relevant.
Checklist for author(s):
feature
orhotfix
branch, in line with our git branching strategy;.env
files if I added, removed, or changed any config options, and I have informed others that they need to modify their.env
files if required;If a non-trivial PR: