-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use setuptools-scm to write correct version to version.py #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reinschaap
approved these changes
Apr 14, 2023
underdarknl
approved these changes
Apr 14, 2023
underdarknl
approved these changes
Apr 14, 2023
Minimum allowed coverage is Generated by 🐒 cobertura-action against bb4b9e6 |
jpbruinsslot
added a commit
that referenced
this pull request
Apr 17, 2023
* main: Update `pre-commit` dependencies and enable Ruff autofix (#739) Cleanup Rocky requirements (#729) Add (I) to ruff and fix imports (#723) Add port-common bit and KAT-OPEN-COMMON-PORT FindingType (#734) Use setuptools-scm to write correct version to version.py (#737) Enable and disable bits (#732) Scan level inheritance chain (#722) Octopoes origin param endpoint (#731) Do not propagate scan level from DNSSPFMechanismHostname (#721) Fix: Unnecessary white space within links (#728) chore/refactor katalogus settings setup (#542)
jpbruinsslot
added a commit
that referenced
this pull request
Apr 17, 2023
* main: Update `pre-commit` dependencies and enable Ruff autofix (#739) Cleanup Rocky requirements (#729) Add (I) to ruff and fix imports (#723) Add port-common bit and KAT-OPEN-COMMON-PORT FindingType (#734) Use setuptools-scm to write correct version to version.py (#737) Enable and disable bits (#732) Scan level inheritance chain (#722) Octopoes origin param endpoint (#731)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version will be the version of the git tag or
0.1.dev1+g<git commit hash>
when there isn't a tag.Also add workflow itself to workflow paths so they tigger if the workflow changes.
Issue link
Please add a link to the issue. If there is no issue for this PR, please add it to the project board directly.
Proof
Checklists for authors:
Code Checklist
Communication
.env
changes files if required and changed the.env-dist
accordingly.Checklist for code reviewers:
Checklist for QA:
make kat
.feature
orhotfix
works as intended.What works:
What doesn't work:
Bug or feature?: