Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix deprecated warning due to old env in .env-defaults #2597

Merged
merged 2 commits into from
Mar 5, 2024
Merged

fix deprecated warning due to old env in .env-defaults #2597

merged 2 commits into from
Mar 5, 2024

Conversation

underdarknl
Copy link
Contributor

Changes

Our default setup was throwing deprecated warnings due to an old env var name being used.

Demo

image

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
  • I have written unit tests for the changes or fixes I made.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have made corresponding changes to the documentation, if necessary.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.

Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@underdarknl underdarknl requested a review from a team as a code owner March 5, 2024 13:44
@dekkers dekkers merged commit e31e09e into main Mar 5, 2024
5 checks passed
@dekkers dekkers deleted the fix/deprecated-warning-boefjes-env branch March 5, 2024 15:10
jpbruinsslot pushed a commit that referenced this pull request Mar 5, 2024
@underdarknl @dekkers @jpbruinsslot
fix deprecated warning due to old env in .env-defaults (#2597)
c8590ab 
Co-authored-by: Jeroen Dekkers <[email protected]>
jpbruinsslot added a commit that referenced this pull request Mar 5, 2024
@jpbruinsslot
Merge branch 'main' into feature/mula/task-events-alternative-2
5cd2e5d 
* main:
  fix deprecated warning due to old env in .env-defaults (#2597)
  add extra checks for findings to dns report (#2506)
  Fix missing finding_type table (#2596)
  Translations update from Hosted Weblate (#2594)
  TLS Report unit tests (#2593)
  Filter out undeserializable objects from xtdb query in `construct_neighbour_query_multi` (#2592)
  Feature/efficient reporting for all reports (#2586)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dekkers dekkers dekkers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
KAT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@underdarknl @dekkers