Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing finding_type table #2596

Merged
merged 5 commits into from
Mar 5, 2024
Merged

Fix missing finding_type table #2596

merged 5 commits into from
Mar 5, 2024

Conversation

madelondohmen
Copy link
Contributor

Changes

This PR makes some small naming changes to the HTML file of the Mail Report, which wasn't showing the compliance-table.

Issue link

Closes #2595

Demo

afbeelding

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
  • I have written unit tests for the changes or fixes I made.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have made corresponding changes to the documentation, if necessary.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.

Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@madelondohmen madelondohmen added bug Something isn't working report labels Mar 5, 2024
@madelondohmen madelondohmen self-assigned this Mar 5, 2024
@madelondohmen madelondohmen requested a review from a team as a code owner March 5, 2024 11:22
@underdarknl underdarknl merged commit 3113c87 into main Mar 5, 2024
10 checks passed
@underdarknl underdarknl deleted the fix/mail_report_table_fix branch March 5, 2024 14:38
jpbruinsslot pushed a commit that referenced this pull request Mar 5, 2024
@madelondohmen @underdarknl
@dekkers @jpbruinsslot
Fix missing finding_type table (#2596)
c5e79db 
Co-authored-by: Jan Klopper <[email protected]>
Co-authored-by: Jeroen Dekkers <[email protected]>
jpbruinsslot added a commit that referenced this pull request Mar 5, 2024
@jpbruinsslot
Merge branch 'main' into feature/mula/task-events-alternative-2
5cd2e5d 
* main:
  fix deprecated warning due to old env in .env-defaults (#2597)
  add extra checks for findings to dns report (#2506)
  Fix missing finding_type table (#2596)
  Translations update from Hosted Weblate (#2594)
  TLS Report unit tests (#2593)
  Filter out undeserializable objects from xtdb query in `construct_neighbour_query_multi` (#2592)
  Feature/efficient reporting for all reports (#2586)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@underdarknl underdarknl underdarknl approved these changes

Assignees

@madelondohmen madelondohmen

Labels
bug Something isn't working report
Projects
KAT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mail Report doesn't show findings
3 participants
@madelondohmen @underdarknl @dekkers